Macro to compare old prices with new prices for stock and show(-/+)

[KalilMe]

Hello,
in QW sheet will be multiple columns contain prices and every time I will add new column contain new prices .
in STOCK sheet contains data in columns A:E
what I want create report in columns G:L with formatting and borders by brings the prices from last column in QW sheet and put in column J , as to column K=column I* column J
column L =column K- column E
in lastrow for column G when amount is minus in column L then populate LOSE word ,amount is plus in column L then populate PROFIT word.
if there is empty cell in last column in QW when brings price from previous column(not the first column) for instance if there is price in columnL,M,N and if the id doesn't existed price in column N then will brings from column M .
when create report will match BATCH column for two sheets , also if there is ID in STOCK sheet and it's not existed in QW sheet then will show as in STOCK sheet.

subtra.xlsm
	J	K	L	M
1	ITEM	BATCH	01/11/2024	02/11/2024
2	1	APP PP FRUIT	12.00	11.00
3	2	BAN FF FRUIT	9.00
4	3	CU CMC VEG	11.00	11.00
5	4	FRU BANN MU	22.00	23.00
6	5	PI PIA FRUIT	21.00	21.00
7	6	PO PTT VEG	12.00	11.00
8	7	TO TMA VEG	5.00	4.00
9	8	TE TEE FOOD	23.00	18.00
10	9	TRB POT BNG	22.00	24.00
QW

subtra.xlsm
	A	B	C	D	E	F	G	H	I	J	K	L	M	N	O
1	ITEM	BATCH	QTY	UNIT PRICE	TOTAL
2	1	TO TMA VEG	10.00	5.00	50.00
3	2	PO PTT VEG	20.00	10.00	200.00
4	3	BAN FF FRUIT	100.00	12.00	1,200.00
5	4	APP PP FRUIT	100.00	10.00	1,000.00
6	5	PI PIA FRUIT	12.00	22.00	264.00
7	6	TE TEE FOOD	100.00	23.00	2,300.00
8	7	CU CMC VEG	120.00	21.00	2,520.00
9	8	TRB POT BNG	100.00	22.00	2,200.00
10	9	FRU BANN MU	124.00	22.00	2,728.00
11
12
13
14
STOCK

result

subtra.xlsm
	A	B	C	D	E	F	G	H	I	J	K	L	M	N	O
1	ITEM	BATCH	QTY	UNIT PRICE	TOTAL		ITEM	BATCH	QTY	UNIT PRICE	TOTAL	D/P
2	1	TO TMA VEG	10.00	5.00	50.00		1	TO TMA VEG	10.00	4.00	40.00	-10.00
3	2	PO PTT VEG	20.00	10.00	200.00		2	PO PTT VEG	20.00	11.00	220.00	20.00
4	3	BAN FF FRUIT	100.00	12.00	1,200.00		3	BAN FF FRUIT	100.00	9.00	900.00	-300.00
5	4	APP PP FRUIT	100.00	10.00	1,000.00		4	APP PP FRUIT	100.00	11.00	1,100.00	100.00
6	5	PI PIA FRUIT	12.00	22.00	264.00		5	PI PIA FRUIT	12.00	21.00	252.00	-12.00
7	6	TE TEE FOOD	100.00	23.00	2,300.00		6	TE TEE FOOD	100.00	18.00	1,800.00	-500.00
8	7	CU CMC VEG	120.00	21.00	2,520.00		7	CU CMC VEG	120.00	11.00	1,320.00	-1,200.00
9	8	TRB POT BNG	100.00	22.00	2,200.00		8	TRB POT BNG	100.00	24.00	2,400.00	200.00
10	9	FRU BANN MU	124.00	22.00	2,728.00		9	FRU BANN MU	124.00	23.00	2,852.00	124.00
11							LOSE					-1,578.00
12
13
STOCK

Cell Formulas
Range	Formula
L2:L10	L2	=K2-E2
L11	L11	=SUM(L2:L10)

I need macro , I don't PQ or PT , formulas
thanks

 

[KalilMe]

ASD FGG TR is missing in QW sheet, how do you want it.

ok well show as in STOCK sheet

 

[kvsrinivasamurthy]

Try.

Sub CreateTable()
Application.ScreenUpdating = False
Dim Lrq&, Lrs&, Lcq&, T&, Ta&
Dim Frng1 As Range, Frng2 As Range

Lrq = Sheets("QW").Range("A" & Rows.Count).End(xlUp).Row
Lcq = Sheets("QW").Cells(1, Columns.Count).End(xlToLeft).Column
With Sheets("STOCK")
.Range("G1").CurrentRegion.Clear
Lrs = .Range("A" & Rows.Count).End(xlUp).Row
.Range("A1").CurrentRegion.Resize(, 3).Copy .Range("G1")
For T = 2 To Lrs
Set Frng1 = Sheets("QW").Range("B2:B" & Lrq).Find(.Range("H" & T).Value)
If Not Frng1 Is Nothing Then
    For Ta = Lcq To 3 Step -1
    If Sheets("QW").Cells(Frng1.Row, Ta) <> "" Then
    .Range("J" & T) = Sheets("QW").Cells(Frng1.Row, Ta)
    Exit For
    End If
    Next Ta
End If
Next T
.Range("K2:K" & Lrs).Formula = "=I2*J2"
.Range("L2:L" & Lrs).Formula = "=K2-E2"
.Range("G1:J1").Copy .Range("J1")
.Range("J1:L1") = Array("UNIT PRICE", "TOTAL", "D/P")
.Range("L" & Lrs + 1).Formula = "=Sum(L2:L" & Lrs & ")"
If .Range("L" & Lrs + 1) < 0 Then .Range("G" & Lrs + 1) = "LOSS" Else .Range("G" & Lrs + 1) = "GAIN"
.Range("H1").CurrentRegion.Borders.LineStyle = xlContinuous
End With

Application.ScreenUpdating = True
End Sub

 

[KalilMe]

@kvsrinivasamurthy

sub.xlsm
	G	H	I	J	K	L
2	1	TO TMA VEG	10.00		0	-50.00
3	2	PO PTT VEG	20.00		0	-200.00
4	3	BAN FF FRUIT	100.00		0	-1,200.00
5	4	APP PP FRUIT	100.00		0	-1,000.00
6	5	PI PIA FRUIT	12.00		0	-264.00
7	6	TE TEE FOOD	100.00		0	-2,300.00
8	7	CU CMC VEG	120.00		0	-2,520.00
9	8	TRB POT BNG	100.00		0	-2,200.00
10	9	ASD FGG TR	124.00		0	-2,728.00
11	10	FRU BANN MU	124.00		0	-2,728.00
12	LOSS					-15,190.00
STOCK

Cell Formulas
Range	Formula
K2:K11	K2	=I2*J2
L2:L11	L2	=K2-E2
L12	L12	=SUM(L2:L11)

 

[Fuji]

Col J:L will be blank when BATCH is missing in QW sheet.
Clear Col.B that is the result of wrong cell reference of previous code, otherwise you will get wrong result again.

Sub test()
    Dim s$(1), i&, x&, r As Range, c As Range, ws As Worksheet
    Application.ScreenUpdating = False
    Set ws = Sheets("stock")
    ws.Columns("g:l").Clear
    With Sheets("qw")
        With .Range("j1", .Cells.SpecialCells(11))
            Set r = .Columns(.Columns.Count + 1)
            r.Cells(1) = "UP"
            r.Cells(2).FormulaArray = Replace("=index(#,max(if(#<>"""",column(#)-9)))", "#", "rc10:rc[-1]")
            r.Cells(2).Resize(r.Rows.Count - 1).FillDown
        End With
    End With
    s(1) = "Provider=Microsoft.Ace.OLEDB.12.0;Data Source=" & _
    ThisWorkbook.FullName & ";Extended Properties='Excel 12.0;HDR=Yes';"
    s(0) = "Select A.`ITEM`, A.`BATCH`, A.`QTY`, B.`UP` As `UNIT PRICE`, " & _
        "A.`QTY` * B.`UP` As `TOTAL`, A.`QTY` * B.`UP` - A.`TOTAL` As `D/P` " & _
        "From `STOCK$` As A Left Join `QW$` As B On A.`BATCH` = B.`BATCH`;"
    With CreateObject("ADODB.Recordset")
        .Open s(0), s(1), 3, 3, 1
        For i = 0 To .Fields.Count - 1
            ws.Cells(1, i + 7) = .Fields(i).Name
        Next
        ws.[g2].CopyFromRecordset .DataSource
    End With
    r.Clear
    With ws.[g1].CurrentRegion
        .HorizontalAlignment = xlCenter
        .Columns("d:l").NumberFormat = "#,0.00"
        Union(.Rows(1), .Rows(.Rows.Count + 1)).Font.Bold = True
        Set c = .Cells(.Rows.Count + 1, .Columns.Count)
        c.Formula = "=sum(r2c:r[-1]c)"
        .Cells(.Rows.Count + 1, 1) = IIf(c > 0, "GAIN", "LOOSE")
        .EntireColumn.AutoFit
        .Resize(.Rows.Count + 1).Borders.Weight = 2
    End With
    Application.ScreenUpdating = True
End Sub

 

[KalilMe]

Clear Col.B that is the result of wrong cell reference of previous code,

I don't understand it!
the new item in STOCK sheet should show even if it's not existed in QW sheet.

 

[Fuji]

I'm talking about the workbook you uploaded.

B1 = UP: B2 = 0 in QW sheet.

You need to clear above, before you run the code.

 

[KalilMe]

ok
but doesn't show rest of data for new item in STOCK sheet in row 11

sub.xlsm
	A	B	C	D	E	F	G	H	I	J	K	L
1	ITEM	BATCH	QTY	UNIT PRICE	TOTAL		ITEM	BATCH	QTY	UNIT PRICE	TOTAL	D/P
2	1	TO TMA VEG	1,000.00	5.00	50.00		1	TO TMA VEG	1000	33.00	33,000.00	32,950.00
3	2	PO PTT VEG	20.00	10.00	200.00		2	PO PTT VEG	20	11.00	220.00	20.00
4	3	BAN FF FRUIT	100.00	12.00	1,200.00		3	BAN FF FRUIT	100	9.00	900.00	-300.00
5	4	APP PP FRUIT	100.00	10.00	1,000.00		4	APP PP FRUIT	100	11.00	1,100.00	100.00
6	5	PI PIA FRUIT	12.00	22.00	264.00		5	PI PIA FRUIT	12	21.00	252.00	-12.00
7	6	TE TEE FOOD	100.00	23.00	2,300.00		6	TE TEE FOOD	100	18.00	1,800.00	-500.00
8	7	CU CMC VEG	120.00	21.00	2,520.00		7	CU CMC VEG	120	11.00	1,320.00	-1,200.00
9	8	TRB POT BNG	100.00	22.00	2,200.00		8	TRB POT BNG	100	24.00	2,400.00	200.00
10	10	FRU BANN MU	124.00	22.00	2,728.00		10	FRU BANN MU	124	23.00	2,852.00	124.00
11	11	FRU we3 MU	124.00	22.00	2,728.00		11	FRU we3 MU	124
12							GAIN					31,382.00
STOCK

Cell Formulas
Range	Formula
L12	L12	=SUM(L$2:L11)

the right

sub.xlsm
	A	B	C	D	E	F	G	H	I	J	K	L
1	ITEM	BATCH	QTY	UNIT PRICE	TOTAL		ITEM	BATCH	QTY	UNIT PRICE	TOTAL	D/P
2	1	TO TMA VEG	1,000.00	5.00	50.00		1	TO TMA VEG	1000	33.00	33,000.00	32,950.00
3	2	PO PTT VEG	20.00	10.00	200.00		2	PO PTT VEG	20	11.00	220.00	20.00
4	3	BAN FF FRUIT	100.00	12.00	1,200.00		3	BAN FF FRUIT	100	9.00	900.00	-300.00
5	4	APP PP FRUIT	100.00	10.00	1,000.00		4	APP PP FRUIT	100	11.00	1,100.00	100.00
6	5	PI PIA FRUIT	12.00	22.00	264.00		5	PI PIA FRUIT	12	21.00	252.00	-12.00
7	6	TE TEE FOOD	100.00	23.00	2,300.00		6	TE TEE FOOD	100	18.00	1,800.00	-500.00
8	7	CU CMC VEG	120.00	21.00	2,520.00		7	CU CMC VEG	120	11.00	1,320.00	-1,200.00
9	8	TRB POT BNG	100.00	22.00	2,200.00		8	TRB POT BNG	100	24.00	2,400.00	200.00
10	10	FRU BANN MU	124.00	22.00	2,728.00		10	FRU BANN MU	124	23.00	2,852.00	124.00
11	11	FRU we3 MU	124.00	22.00	2,728.00		11	FRU we3 MU	124	22.00	2,728.00	0.00
12							GAIN					31,382.00
STOCK

Cell Formulas
Range	Formula
K11	K11	=I11*J11
L11	L11	=K11-E11
L12	L12	=SUM(L$2:L11)

 

[Peter_SSs]

the right

Can we see the QW sheet that was used to come up with those last "right" results?

 

[KalilMe]

Can we see the QW sheet that was used to come up with those last "right" results?

this is not existed in QW sheet

sub.xlsm
	J	K	L	M	N
1	ITEM	BATCH	01/11/2024	02/11/2024	03/11/2024
2	1	APP PP FRUIT	12.00	11.00	11.00
3	2	BAN FF FRUIT	9.00
4	3	CU CMC VEG	11.00	11.00	11.00
5	4	FRU BANN MU	22.00	45.00
6	5	PI PIA FRUIT	21.00	21.00	21.00
7	6	PO PTT VEG	12.00	11.00	11.00
8	7	TO TMA VEG	5.00	4.00	33.00
9	8	TE TEE FOOD	23.00	18.00	18.00
10	9	TRB POT BNG	22.00	24.00	24.00
11	10	TRB AAT tt	23.00	24.00	24.00
QW

 

[Fuji]

Change

    s(0) = "Select A.`ITEM`, A.`BATCH`, A.`QTY`, B.`UP` As `UNIT PRICE`, " & _
        "A.`QTY` * B.`UP` As `TOTAL`, A.`QTY` * B.`UP` - A.`TOTAL` As `D/P` " & _
        "From `STOCK$` As A Left Join `QW$` As B On A.`BATCH` = B.`BATCH`;"

to

    s(0) = "Select A.`ITEM`, A.`BATCH`, A.`QTY`, IIf(IsNull(B.`UP`), A.`UNIT PRICE`, B.`UP`) As `UNIT PRICE`, " & _
        "IIf(IsNull(B.`UP`), A.`TOTAL`, A.`QTY` * B.`UP`) As `TOTAL`, A.`QTY` * B.`UP` - A.`TOTAL` As `D/P` " & _
        "From `STOCK$` As A Left Join `QW$` As B On A.`BATCH` = B.`BATCH`;"