Workbook open not working when run automatically

[Uzma Shaheen]

Hi

I have some code on workbook open that checks to see the height and width of the active window and it then changes the zoom depending on which criteria it falls into

Now when I run it on the workbook open - it doesn’t change to the correct zoom view but when I step through it manually it does and I’m not sure why it only works when I step through it manually

I don’t have the code to hand at the mo and will post when I get access to a computer but was hoping someone could help and see if it’s a common issue


thanks

 

[Scott T]

Is the code in the ThisWorkbook module?

 

[Uzma Shaheen]

Hi

yes it is

 

[Scott T]

Would need to see the code to see what the problem is.

 

[Uzma Shaheen]

Here is all the code - i dunno if excel is running so quick that it doesnt pick up the active window height/width on the workbook open code but again when i run it manually and step through - it works fine. Every code works fine when stepping through it

This workbook code

[/B]Private Sub Workbook_BeforeClose(Cancel As Boolean)


    Dim dWidth As Double
    Dim dHeight As Double
    
    Application.ExecuteExcel4Macro "SHOW.TOOLBAR(""Ribbon"",True)"
    Application.DisplayFormulaBar = True
    Application.DisplayStatusBar = True
    ActiveWindow.DisplayWorkbookTabs = True
    ActiveWindow.DisplayHorizontalScrollBar = True
    ActiveWindow.DisplayVerticalScrollBar = True
    
     dWidth = ActiveWindow.Width
     dHeight = ActiveWindow.Height
    
'=======LOADING SCREEN=============='
   
    'Home Monitor '792 height '1452 width
    If dHeight = 792 And dWidth = 1452 Then
        ActiveWindow.Zoom = 106
        
    'Desktops '792 height '1452 width
    ElseIf dHeight = 769.5 And dWidth = 1272 Then
        ActiveWindow.Zoom = 100
            
    Else
    'Use Standard Default View Zoom
        ActiveWindow.Zoom = 106
    End If
    
Application.ScreenUpdating = True


End Sub
    




Private Sub Workbook_BeforeSave(ByVal SaveAsUI As Boolean, Cancel As Boolean)


Application.ScreenUpdating = False


Dim dWidth As Double
Dim dHeight As Double


Application.ExecuteExcel4Macro "SHOW.TOOLBAR(""Ribbon"",True)"
Application.DisplayFormulaBar = True
Application.DisplayStatusBar = True
ActiveWindow.DisplayWorkbookTabs = True
ActiveWindow.DisplayHorizontalScrollBar = True
ActiveWindow.DisplayVerticalScrollBar = True
Worksheets("Home").Visible = True
Application.GoTo Sheets("HOME").Range("A1"), Scroll:=True
    
    Set ws = Sheets("HOME")
    Set shp = ws.Shapes("GROWBAR")
    shp.Width = 0
    
    dWidth = ActiveWindow.Width
    dHeight = ActiveWindow.Height
    
'=======LOADING SCREEN=============='
   
    'Home Monitor '792 height '1452 width
    If dHeight = 792 And dWidth = 1452 Then
        ActiveWindow.Zoom = 106
        
    'Desktops '792 height '1452 width
    ElseIf dHeight = 769.5 And dWidth = 1272 Then
        ActiveWindow.Zoom = 100
          
    Else
    'Use Standard Default View Zoom
        ActiveWindow.Zoom = 106
    End If
    
Application.ScreenUpdating = True


End Sub


Private Sub Workbook_Open()




Dim dWidth As Double
Dim dHeight As Double


Set ws = Sheets("HOME")


'Application.Goto Worksheets("HOME").Range("A1"), Scroll:=True


ActiveWindow.WindowState = xlMaximized
Application.EnableCancelKey = xlDisabled
Application.ExecuteExcel4Macro "SHOW.TOOLBAR(""Ribbon"",False)"
Application.DisplayFormulaBar = False
Application.DisplayStatusBar = Not Application.DisplayStatusBar
ActiveWindow.DisplayWorkbookTabs = False
ActiveWindow.DisplayHorizontalScrollBar = False
ActiveWindow.DisplayVerticalScrollBar = False
    
dWidth = ActiveWindow.Width
dHeight = ActiveWindow.Height
    
'=======LOADING SCREEN=============='
   
    'Home Monitor '792 height '1452 width
    If dHeight = 792 And dWidth = 1452 Then
        ActiveWindow.Zoom = 106


    'Desktops '792 height '1452 width
    ElseIf dHeight = 769.5 And dWidth = 1272 Then
        ActiveWindow.Zoom = 100
  
    Else
    'Use Standard Default View Zoom
        ActiveWindow.Zoom = 106
   
    End If
       
Application.ScreenUpdating = True


End Sub

Worksheet event Codes on Worksheet HOME

Private Sub Worksheet_Activate()


Dim dWidth As Double
Dim dHeight As Double


    ActiveWindow.WindowState = xlMaximized
    Application.ExecuteExcel4Macro "SHOW.TOOLBAR(""Ribbon"",False)"
    Application.DisplayFormulaBar = False
    Application.DisplayStatusBar = Not Application.DisplayStatusBar
    ActiveWindow.DisplayWorkbookTabs = False
    ActiveWindow.DisplayHorizontalScrollBar = False
    ActiveWindow.DisplayVerticalScrollBar = False


    dWidth = ActiveWindow.Width
    dHeight = ActiveWindow.Height


'=======LOADING SCREEN=============='


    'Home Monitor '792 height '1452 width
    If dHeight = 792 And dWidth = 1452 Then
        ActiveWindow.Zoom = 106


    'Desktops '792 height '1452 width
    ElseIf dHeight = 769.5 And dWidth = 1272 Then
        ActiveWindow.Zoom = 100


    Else
    'Use Standard Default View Zoom
        ActiveWindow.Zoom = 106
    End If


End Sub


Private Sub Worksheet_Deactivate()
    Application.ExecuteExcel4Macro "SHOW.TOOLBAR(""Ribbon"",True)"
    Application.DisplayFormulaBar = True
    Application.DisplayStatusBar = True
    ActiveWindow.DisplayWorkbookTabs = True
    ActiveWindow.DisplayHorizontalScrollBar = True
    ActiveWindow.DisplayVerticalScrollBar = True
End Sub

 

[Scott T]

The code runs for me when the workbook is opened.

Make sure you have events turned on.

Application.EnableEvents = True

 

[Uzma Shaheen]

Hi - for some reason it doesn’t work for me

shall I add enable events at the start of the code and also an application.wait to ensure it captures the height/width?

 

[Scott T]

Hi - for some reason it doesn’t work for me

shall I add enable events at the start of the code and also an application.wait to ensure it captures the height/width?

If events are off then your code will not run as it is based on a event but events are off. You can type it in the immediate window of the VBA editor or in a module just have a sub that has the line of code. Run it to make sure events are on and then try opening your file and see if the open event runs.

 

[Uzma Shaheen]

The event open definitely works because I’ve added in some more code at the end to update some cells with some values and that works and updates / it’s just the zoom part that it falls over on and I’m thinking is excel going to quick?

Would I need to add a wait and if yes which part shall I add it in?

 

[Scott T]

You can add a wait but I do not see how that would help. Your code runs for me without a wait.

it’s just the zoom part that it falls over on and I’m thinking is excel going to quick?

So the other lines run OK? the ribbon, and formula bar are hidden?