VBA Select Case error: procedure too large

[angela022687]

Hi,

I have 30 different cases working well in one module so far. Now I need to add some more cases, but the system doesn’t allow me to start defining any new cases under Select – Case, it shows: compile error: procedure too large.

I’m thinking maybe there’s a way to combine multiple cases like Case 30, 31, 32 in one statement, and use if, else to define each one?? So the coding won’t return the “Procedure Too Large” error? see my original coding as below:

counter = 0
colkey = 0
For Each cont In PriceForm.HaveFrame.Controls
If TypeName(cont) = "CheckBox" Then
counter = counter + 1
check = cont.Value
If check = True Then
colkey = colkey + 1
Select Case counter
Case 1
have.Add Item:="Product 1", Key:=CStr(colkey)
Case 2
have.Add Item:=" Product 1", Key:=CStr(colkey)
……………
Case 31
have.Add Item:=" Product 31", Key:=CStr(colkey) '''After I added this case, it returned” Procedure Too Large” error
End Select
End If
End If
Next cont

Does anyone know what’s the problem here?

Thanks in advance!

 

[angela022687]

This may be a silly suggestion, but are you applying the same thing to each case? If so, why not apply multiple cases?

Select Case counter
Case 1 to 31
have.Add Item:="Product name", Key:=CStr(colkey)
End Select

The product name would be the only tricky part for a newbie like myself, but I'm positive it's doable!

the product name is a tricky part for me too if i'm combining all cases into one statement

 

[Norie]

The advantage of using a multiselect listbox is that you would only be dealing with one control.

Also, it would be straightforward to loop through the items listed in the listbox and see which ones have been selected.

By the way, what are the the captions of the checkboxes?

If it's the products then why not use them in your code?