VBA Overflow Error Not Caused by Integer/Long

rdmea1

New Member
Joined
Jun 1, 2003
Messages
45
Hello,

I'm a mid-level VBA user and so I've searched and modified the following code to loop through 5 files, each with a "Master" tab. It's worked for months now, but threw an overflow error today on the highlighted piece of code. It's odd because it's crashing between rows 82729 and 132711 (stops mid loop), but I successfully pulled in 139090 rows last week. I'd previously had an issue of using Integer instead of Long for the variables, but I'd fixed that a few months ago.

The debugger highlights the following code: destrange.Value = sourceRange.Value

I'd appreciate any guidance you could offer.

Regards

Rob

Code:
Sub Get_AP_Data()
    Dim MyPath As String, FilesInPath As String
    Dim MyFiles() As String
    Dim SourceRcount As Long, Fnum As Long
    Dim mybook As Workbook, BaseWks As Worksheet
    Dim sourceRange As Range, destrange As Range
    Dim rnum As Long, CalcMode As Long

    'Fill in the path\folder where the files are
    MyPath = "J:\Payments\Consolidated\AP Data Files"

    'Add a slash at the end if the user forget it
    If Right(MyPath, 1) <> "" Then
        MyPath = MyPath & ""
    End If

    'If there are no Excel files in the folder exit the sub
    FilesInPath = Dir(MyPath & "*.xl*")
    If FilesInPath = "" Then
        MsgBox "No files found"
        Exit Sub
    End If

    'Fill the array(myFiles)with the list of Excel files in the folder
    Fnum = 0
    Do While FilesInPath <> ""
        Fnum = Fnum + 1
        ReDim Preserve MyFiles(1 To Fnum)
        MyFiles(Fnum) = FilesInPath
        FilesInPath = Dir()
    Loop

    'Change ScreenUpdating, Calculation and EnableEvents
    With Application
        CalcMode = .Calculation
        .Calculation = xlCalculationManual
        .ScreenUpdating = False
        .EnableEvents = False
    End With

    'Add a new workbook with one sheet
    Set BaseWks = ActiveSheet
    rnum = 2

    'Loop through all files in the array(myFiles)
    If Fnum > 0 Then
        For Fnum = LBound(MyFiles) To UBound(MyFiles)
            Set mybook = Nothing
            On Error Resume Next
            Set mybook = Workbooks.Open(MyPath & MyFiles(Fnum))
            On Error GoTo 0

            If Not mybook Is Nothing Then

                On Error Resume Next

                With mybook.Worksheets("Master")
                    Dim Lastrow As Long
                    Lastrow = ActiveSheet.Cells(Rows.Count, 1).End(xlUp).Row
                    Set sourceRange = .Range("A2:M" & Lastrow)
                End With
                  
                If Err.Number > 0 Then
                    Err.Clear
                    Set sourceRange = Nothing
                Else
                    'if SourceRange use all columns then skip this file
                    If sourceRange.Columns.Count >= BaseWks.Columns.Count Then
                        Set sourceRange = Nothing
                    End If
                End If
                On Error GoTo 0

                If Not sourceRange Is Nothing Then

                    SourceRcount = sourceRange.Rows.Count

                    If rnum + SourceRcount >= BaseWks.Rows.Count Then
                        MsgBox "Sorry there are not enough rows in the sheet"
                        BaseWks.Columns.AutoFit
                        mybook.Close savechanges:=False
                        GoTo ExitTheSub
                    Else

                        'Set the destrange
                        Set destrange = BaseWks.Range("A" & rnum)

                        'we copy the values from the sourceRange to the destrange
                        With sourceRange
                            Set destrange = destrange. _
                                            Resize(.Rows.Count, .Columns.Count)
                        End With
                        destrange.Value = sourceRange.Value

                        rnum = rnum + SourceRcount
                    End If
                End If
                mybook.Close savechanges:=False
            End If

        Next Fnum
        BaseWks.Columns.AutoFit
    End If

ExitTheSub:
    'Restore ScreenUpdating, Calculation and EnableEvents
    With Application
        .ScreenUpdating = True
        .EnableEvents = True
        .Calculation = CalcMode
    End With
End Sub
 
Last edited by a moderator:

Excel Facts

Whats the difference between CONCAT and CONCATENATE?
The newer CONCAT function can reference a range of cells. =CONCATENATE(A1,A2,A3,A4,A5) becomes =CONCAT(A1:A5)
That is a lot of code to go through... it might help if you told us which line of code was highlighted in yellow when the overflow error occured.
 
Upvote 0
Rick,

My apologies, I edited the initial post to identify the line of code, but I'm struggling to highlight it. It's about 20 lines from the bottom. destrange.Value = sourceRange.Value

Thanks for the interest and any potential help.
 
Upvote 0
Code:
Set destrange = destrange.Resize(.Rows.Count, .Columns.Count)
debug.print destrange.address

What's that show?
 
Upvote 0
shg,

Thanks for the response. I've just become aware of the "debug" coding, so I assumed you meant for me to insert your code into my code exactly after the "Set destrange...". Having done that, it errors out without providing any message. As before, I get the overflow message and the process ends with my consolidation file open and one of the input files.

Regards,

Rob
 
Upvote 0
How about using debug like.
What does this say?
Code:
   With SourceRange
      [COLOR=#ff0000]Debug.Print .Rows.Count, .Columns.Count, DestRng.Address[/COLOR]
      Set DestRange = DestRange. _
      Resize(.Rows.Count, .Columns.Count)
   End With
 
Last edited:
Upvote 0
Fluff,

I assumed you mean "DestRange.Address", but please let me know if you did not. Unfortunately, I still get the same result. Overflow error 6, without any debugging information and two files open.

Thanks,

Rob
 
Upvote 0
I did indeed mean DestRange.

The Lastrow section of your code is wrong, it should be
Code:
                With mybook.Worksheets("Master")
                    Dim Lastrow As Long
                    Lastrow = .Cells(.Rows.Count, 1).End(xlUp).Row
                    Set sourceRange = .Range("A2:M" & Lastrow)
                End With
otherwise you are calculating Last row based on the active sheet, rather than the "Master" sheet.
That said it shouldn't be causing the error.
Are all you files "New style" (ie .xlsx, xlsm ) or are any of them .xls files?
 
Upvote 0
Fluff,

Respectfully, I don't think that section of code is wrong because it's worked for months. Each of the input files has a tab called "Master", which is itself a consolidation of weekly data tabs. So, the loop is to open the input files, find the range A2:Mxxx and copy that to my consolidation file, which is the ActiveSheet (I start the macro from a button on the correct tab).

No, all of the files are .xlsm

Again, thanks for taking the time to help.

Regards,

Rob
 
Upvote 0
The code as you had it will only work correctly IF the Master sheet is the active sheet when you open the workbook.
If it's not the active sheet then you will be calculating Lastrow based on another sheet
 
Upvote 0

Forum statistics

Threads
1,223,911
Messages
6,175,337
Members
452,636
Latest member
laura12345

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top