VBA - Greater than or equal to not working with dates.

[RockandGrohl]

Hopefully a quick one. I'm referencing a date (31/12/2018) as a variable "date1"

I'm then going onto another sheet and saying if the value in B is >= date1 and <= date2 then do this.

When I set it to 31/12/2018, even though this cell is less than the value in B (which is 07/01/2019), it doesn't work. However, if I change date1 to be 01/01/2019 it does work.

Somehow 01/01/2019 is valid as being less than 07/01/2019, but 31/12/2018 isn't working.

Any ideas?

Thanks.

 

[RockandGrohl]

You are actually NOT declaring those variables as dates.
Look at your DIM line at the top.

... [COLOR=#333333]date1 As [/COLOR][COLOR=#ff0000]String[/COLOR][COLOR=#333333], date2 As [/COLOR][COLOR=#ff0000]String[/COLOR][COLOR=#333333] ...[/COLOR]

Change that to "As Date" for both of them.

Ah, I see.

Would this have an effect where, later on in the code we have things like "name = date 1 & wbyr & "Commission" - so where multiple things are concatenated together?

 

[Joe4]

So, you can store numbers/dates in a string field, but then become a string, and you cannot do things like date math on them. That is what is happening to you.

Would this have an effect where, later on in the code we have things like "name = date 1 & wbyr & "Commission" - so where multiple things are concatenated together?

You can concatenate variables of different types together. That is not an issue. However, if you want the date part to appear in a particular format, you will want to apply the VBA Format function to it (looks pretty much the same as the Excel Text function).

So, you may have something like this:

[COLOR=#333333]name = FORMAT(date1,"yyyy/mm/dd") & wbyr & " Commission"[/COLOR]