VBA array - referring to different worksheet

kevin chan

New Member
Joined
Aug 3, 2018
Messages
3
I have this code which reads data into an array.
For some reason this works:
Code:
Function TotalCost(col As Integer) As Double
Dim pricedata As Variant
Dim maxrows as Integer

maxrows = Worksheets(DATASHEET).Cells(Worksheets(DATASHEET).Rows.Count, col).End(xlUp).row
pricedata = Range(Cells(1, col), Cells(maxrows, col + 5)).Value
code goes on….
But this fails on the "pricedata=" line:
Code:
Function TotalCost(col As Integer) As Double
Dim pricedata As Variant
Dim maxrows as Integer

maxrows = Worksheets(DATASHEET).Cells(Worksheets(DATASHEET).Rows.Count, col).End(xlUp).row
pricedata = Worksheets(DATASHEET).Range(Cells(1, col), Cells(maxrows, col + 5)).Value
code goes on…

The key difference is in the pricedata = line. It refers to a different worksheet
I am trying to read a contiguous block of data into an array, but I can get it to work on the same worksheet but not if it refers to another worksheet.
DATASHEET is a global constant in this case with the sheet name.
Can anyone help me with an alternative way to code this?
Thanks!
 

Excel Facts

Copy a format multiple times
Select a formatted range. Double-click the Format Painter (left side of Home tab). You can paste formatting multiple times. Esc to stop
Try either
Code:
pricedata = Worksheets(DATASHEET).Range(Worksheets(DATASHEET).Cells(1, col), Worksheets(DATASHEET).Cells(maxrows, col + 5)).Value
or
Code:
Code:
    With Worksheets(DATASHEET)
        pricedata = .Range(.Cells(1, col), .Cells(maxrows, col + 5)).Value
    End With
 
Upvote 0
Hi perhaps the first thing would be to change maxrows int to long.

Second use

Dim tws, gws As Excel.Worksheet
Set tws = ThisWorkbook.ActiveSheet
set gws = ThisWorkbook.Worksheets(DATASHEET) 'global worksheet


then it will be easier to count cells in proper worksheet any time you use cell or range. tws.cell...
 
Upvote 0

Forum statistics

Threads
1,224,826
Messages
6,181,192
Members
453,021
Latest member
pingpong7117

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top