Simple VBA question (i think)

[deletedalien]

i have this line of code:

               If Worksheets("Summary Inbound").Range("A1").Value = "Error" Then GoTo Exit1
Exit1:
              Application.ScreenUpdating = True
               MsgBox "Error", vbCritical
               Exit Sub

and the following formula in Summary inbound A1
=IF(COUNTIF('Inbound Detail'!AF1:AH1,"error")>0,"ERROR","Ok")

and for whatever reason regardless if A1 says "ok" or "error" it always triggers Exit1 sub routine.

What am i doing wrong?

Thanx in advance.

 

[Jonmo1]

if A1 states that there is an error the rest of the code should stop and an error message should popup basically stating that the user did something wrong.

Then 'the rest of the code' belongs 'BETWEEN' the IF and Next1:
Like I showed in Post #2
MsgBox "Hello" is 'the rest of the code' that stops

 

[Jonmo1]

You also need an Exit Sub after 'the rest of the code' before Exit1

If Worksheets("Summary Inbound").Range("A1").Value = "Error" Then GoTo Exit1
MsgBox "Hello"
Exit Sub

Exit1:
              Application.ScreenUpdating = True
               MsgBox "Error", vbCritical
               Exit Sub

 

[deletedalien]

VBA code still just executes one line at a time, and in order.

Exit1: isn't a 'Sub'. It's just the next line of code.


The purpose of the Then Goto Exit1 would be to make the code NOT execute something..
That line is going to run no matter what.

Here is a more appropriate usage of it.

If Worksheets("Summary Inbound").Range("A1").Value = "Error" Then GoTo Exit1
MsgBox "Hello"

Exit1:
              Application.ScreenUpdating = True
               MsgBox "Error", vbCritical
               Exit Sub

The Message Box will be skipped if the condition is true and it then goes to Exit1

This displays both the "hello" message

And the "Error" Message regardless of the result in A1.

 

[deletedalien]

The code after Exit1: will execute always regardless of the true/false result of your IF.
Simply because it's the next line of code after the if.
There is nothing telling VBA to 'skip' that code.

ok how can i tell vba to stop or keep going depending on the result of A1

 

[deletedalien]

now, i'm just testing this single "test" macro and it still always displays the error message in the vbexclamation: (regardless of value in cell A1 or Case

Sub test()
 If Worksheets("Summary Inbound").Range("A1").Value = "ERROR" Then GoTo Exit1
Exit1:
              Application.ScreenUpdating = True
               MsgBox "Error", vbCritical
               Exit Sub
End Sub

 

[deletedalien]

I figured it out and yes Jonmo1 you where right.

i just didn't catch it at first haha sorry bout that..