Resize of cells in different codes displays an error. Required to edit to count <=0 or >0

[RAJESH1960]

Hello guys

First of all, I am very grateful, to JohnnyL for sharing the codes with comments. With the help of formulas and codes shared by many of the members in the forum and with the help of JohnnyL’s comments, I have tried to edit and create my first code. Thank you to each of them.

I tried to edit JohnnyL’s code to improvise and edited major changes and some additional changes in it. Except for some manual work, I have the code good and running but I am stuck at some places for which I need your expertise to complete it. I have commented some of the issues, in all the codes which need to be replaced by editing some lines. Out of the 7 macro buttons, 2 are dummy as mentioned next to the macro. Those steps have to be done manually, To get the final result, the macro buttons have to be pressed in the same order.

Now, for the problems I could not solve and need your expertise to solve and complete this project.

• I have to manually select the cells from AC2 to AU2 and double click every time. I need help to write the code in such a way that it can be included in the “Move PasteData to CopyData” code.
• When I press the button “Get NA Ledgers to MasterData”, and if there are no NA ledgers in the MasterData sheet, it generates an error. Hence I need to add an extra line If B2 =<1 Then exit sub… else play the rest of the code… something like that. Same solution goes for all the other button codes.
• In each code where changes are required, which I was unable to write the code, I have commented at each line where the code requires editing.
• The split address code is in the MasterData sheet which displays the correct result when played in that sheet only. Also, it doesn’t run in option explicit. I need your expertise to correct the code and include it one of the above codes wherever it is required.
• Most of the Application lines of code have changed or deleted while editing each macro - Application.ScreenUpdading, True / False, Application.CutCopyMode = False / True, etc., I have no idea why and where to place them.
• When the project is over, there will be only 2 sheets on display – List of Ledgers and PasteData. Rest of the sheets need to be hidden with a code. (This is possible and I can do it once the above problems are solved.
• Finally, for the most difficult and biggest problem. Enter January and February in List of ledgers sheet Cells A1 and A2 respectively and run the buttons one by one.

If possible, then, try to combine all the 7 codes in 2 or max 3 buttons. I would really appreciate that. Like ClearData, Generate Master XML and Generate Purchases XML. Just wondering if it is possible, to put it all in one button and get 2 xml’s generated and saved on the desktop.

Please note: I have a copy of all the sheets in the workbook and hidden it. By any chance, while testing or editing the code, it gets deleted or the formulas and data are deleted, it will not be a problem to copy the data again - by clicking the select sheet button, copy and paste.

Important Note: Please do not run JohnnyL’s code. It is just for reference only as the presentation,working and range of cells in the code of the sheets have changed.
Edit & Combine codes.xlsm

 

[RAJESH1960]

Dim Data, Ledger, Chk, i As Long

Dim LedgerCount As Long

'

With Sheets("CopyData")

Data = .Range("N2:N" & .Cells(.Rows.Count, 14).End(xlUp).Row).Value

End With

'

With Sheets("List of Ledgers")

Ledger = .Range("A1:A" & .Cells(.Rows.Count, 1).End(xlUp).Row).Value

End With

'

ReDim Temp(1 To UBound(Data))

With there is just one line of data in the Paste data sheet, in the Get_NA_Ledgers code, it is showing a type mismatch error here at the " ReDim Temp(1 To UBound(Data))" I think here also you need to edit and add this code to if <0 or <1.

 

[RAJESH1960]

With

When ?

 

[johnnyL]

Delete January from the list of ledgers sheet, Row A1 only and check. The master data sheet is again copying the headings in this case too.

See if this addresses that issue:

Sub Get_NA_Ledgers()
'
    Dim Data, Ledger, Chk, i As Long
    Dim LedgerCount As Long
    Dim rng         As Range
'
    With Sheets("CopyData")
        Data = .Range("N2:N" & .Cells(.Rows.Count, 14).End(xlUp).Row).Value
    End With
'
    With Sheets("List of Ledgers")
        On Error Resume Next                                                                    '   If error occurs, skip it and go to next line
        Set rng = Intersect(.UsedRange, Range("A:A"))                                           '   Set the range to scan for blank cells ... Column A
        rng.SpecialCells(xlCellTypeBlanks).Delete shift:=xlUp                                   '   Delete any found blank cells in the range
        On Error GoTo 0                                                                         '   Turn excel error handling back on
'
        Ledger = .Range("A1:A" & .Cells(.Rows.Count, 1).End(xlUp).Row).Value
    End With
'
    ReDim Temp(1 To UBound(Data))
'
    With CreateObject("Scripting.Dictionary")
        For i = 1 To UBound(Data)
            Chk = Application.Match(Data(i, 1), Application.Index(Ledger, , 1), 0)
            If IsError(Chk) And Not .Exists(Data(i, 1)) Then .Add Data(i, 1), ""
        Next i
'
        If .Count > 0 Then                                                                      '   If dictionary count > 0 then ...
            Sheets("MasterData").Range("B2").Resize(.Count) = Application.Transpose(.keys)
            LedgerCount = .Count                                                                '       Save the LedgerCount
        Else
            MsgBox "All Ledgers Available."                                                     '       Display message to user
        End If
    End With
'
    Sheets("MasterData").Range("C:E").NumberFormat = "General"                                  ' Set columns to General format

' Convert existing formulas on 'MasterData' sheet to use LastRow detected instead of hard coded '30'
    Sheets("MasterData").Range("C2").Formula = "=IFERROR(IF(B2="""","""",VLOOKUP(B2,CopyData!$N$2" & _
            ":$O$" & Sheets("CopyData").Cells(Rows.Count, 1).End(xlUp).Row & ",2,0)),"""")"     ' Write updated formula to C2

    Sheets("MasterData").Range("D2").Formula = "=IFERROR(VLOOKUP(LEFT($C2,2)+0," & _
            "'States Code'!$A$1:$B$37,2,0),"""")"                                               ' Write formula to D2
    
    Sheets("MasterData").Range("E2").Formula = "=IFERROR(VLOOKUP(B2,CopyData!$N$2:$P$" & _
            Sheets("CopyData").Cells(Rows.Count, 1).End(xlUp).Row & ",3,0),"""")"               ' Write updated formula to E2
'
    If LedgerCount > 0 Then Sheets("MasterData").Range("C2:E" & _
            Sheets("MasterData").Cells(Rows.Count, 2).End(xlUp).Row).FillDown                   ' Copy the C2:E2 formulas down to last row of B
'
    Application.Goto Sheets("List of Ledgers").Range("A1")                                      ' Return to 'List of Ledgers' sheet cell A1
End Sub

 

[RAJESH1960]

Type Mismatch at this line

    ReDim Temp(1 To UBound(Data))

 

[johnnyL]

My last post is in regards to your previous question.

 

[RAJESH1960]

The issue still persists. The Headings of the master data are copied down in the 2nd row.

 

[johnnyL]

Hmmm.

 

[RAJESH1960]

One more new issue when I run the code, It is affecting the list of ledgers list. After deleting January, the row is deleted or the data is shifted up after running the code

 

[RAJESH1960]

If I am right this line it should be Sheets copy data not list of ledgers

With Sheets("List of Ledgers")
        On Error Resume Next                                                                    '   If error occurs, skip it and go to next line
        Set rng = Intersect(.UsedRange, Range("A:A"))                                           '   Set the range to scan for blank cells ... Column A
        rng.SpecialCells(xlCellTypeBlanks).Delete shift:=xlUp                                   '   Delete any found blank cells in the range
        On Error GoTo 0

 

[johnnyL]

One more new issue when I run the code, It is affecting the list of ledgers list. After deleting January, the row is deleted or the data is shifted up after running the code

Correct. I figured that would solve the problem. You said to delete January from the top of Column A which leaves a blank. The code I added deletes that blank and shifts the column A up. Do you see a problem with that, something that would affect the rest of the program?