Problems do while with multiple criteria

[bbaixinho]

Hi everyone,

I am trying to use a Do while with multiple conditions for an inputbox but it doesn't work.

My code:
'---------------------
dim x as variant
dim y as variant
Do While x - y <= 0 Or x-y > 30 or isnumeric(x)=false
x = InputBox("Invalid value. Please insert")
If StrPtr(numberclaimyear) = 0 Then 'when the user choose the option cancel in inputbox
Exit Sub
End If
Loop


'--------
this code is not working when I insert a letter. I don't understand why because if I use only the condition "do while isnumeric(x)=false" and I insert 1 letter it works..


Thanks in advance!

 

[Jeffrey Mahoney]

Hi bb, welcome to the forum

So, trying to break this down. Using a variant in this case may be the issue. If you enter a letter then this statement will fail: x-y. Because x is no longer a number when you enter a letter into the input box. You may want to test for "isNumeric" first.

I actually like to store the Inputbox into a string, test to see if it's a number, convert it to a value and store it into a number variable.

Try this

  Dim v As Variant  Dim X As Single
  Dim Y As Single
  
  Do
    v = InputBox("Invalid value. Please insert")
    If Len(v) = 0 Then Exit Do
    If IsNumeric(v) = True Then
      X = Val(A)
      If X - Y > 0 Or X - Y <= 30 Then Exit Do
    End If
  Loop

 

[bbaixinho]

works perfectly! Thanks!!