Please check my VBA CODE; I have to be sure I'm doing it correct. Thanks for helping!

[pedie]

Hi Everyone!
My code is working perfect i guess for now but I have to make sure things are placed accordingly like error handling etc....as i dont want problem to occur latter.

Thanks again!
Pedie

Sub try12()
Application.ScreenUpdating = False
Dim wb As Workbook, MyFile As String
Dim sh As String
sh = Sheet1.Range("B1").Value
    MyFile = "D:\Book2.xlsm"
    On Error Resume Next
        Set wb = Workbooks.Open(Filename:=MyFile, Password:="trytry")
              On Error GoTo 0
    If wb Is Nothing Then MsgBox "Error.....": Exit Sub
    Windows("Book2.xlsm").Activate
    [COLOR=blue]On Error GoTo ErrHandl[/COLOR]
    Worksheets(sh).Visible = xlSheetVisible
    ActiveSheet.Activate
    Sheet1.Range("A51:K51").Copy
    Windows("Book2.xlsm").Activate
    Range("A1").Select
    ActiveSheet.Paste
    Worksheets(sh).Visible = xlSheetVeryHidden
    wb.Close savechanges:=True
    Application.CutCopyMode = False
    ActiveSheet.Range("A3").Select
    MsgBox "Done"
[COLOR=blue]    Exit Sub[/COLOR]
[COLOR=blue]ErrHandl:[/COLOR]
[COLOR=blue]    MsgBox "Neee", vbInformation[/COLOR]
    [COLOR=blue]wb.Close savechanges:=False[/COLOR]
Application.ScreenUpdating = True
End Sub

 

[VoG]

Untested but perhaps

Sub try12()
Dim wb As Workbook, MyFile As String
Dim sh As String
Application.ScreenUpdating = False
sh = Sheet1.Range("B1").Value
MyFile = "D:\Book2.xlsm"
On Error Resume Next
Set wb = Workbooks.Open(Filename:=MyFile, Password:="trytry")
On Error GoTo 0
If wb Is Nothing Then MsgBox "Error.....": Exit Sub
On Error GoTo ErrHandl
Worksheets(sh).Visible = xlSheetVisible
Worksheets(sh).Range("A51:K51").Copy Destination:=Workbooks("Book2.xlsm").Sheets("Sheet1").Range("A1")
Worksheets(sh).Visible = xlSheetVeryHidden
wb.Close savechanges:=True
Application.CutCopyMode = False
MsgBox "Done"
Exit Sub
Application.ScreenUpdating = True
ErrHandl:
MsgBox "Pedie was here", vbInformation
Application.ScreenUpdating = True
End Sub

 

[meldoc]

Hello Peter

Shouldnt that be.

MsgBox "Done"
Application.ScreenUpdating = True
Exit Sub
ErrHandl:

Or the sub could end, with ScreenUpdating set to False.

 

[VoG]

Hello Peter

Shouldnt that be.

MsgBox "Done"
Application.ScreenUpdating = True
Exit Sub
ErrHandl:[

/CODE]Or the sub could end, with ScreenUpdating set to False.[/QUOTE]Yes, you are correct.

 

[pedie]

Hi Vog, didnt know your name was Peter, Brian, thanks for letting me know that...

Anyways thanks alot for helping. Yesterday there was blackout here and hence no NET..... Thanks again .... have a great day ahead!

Pedie