Next usage in For Each Loop

[jaybee3]

 Dim oFile As Object, oFolder As Object
 
Set oFolder = CreateObject("scripting.filesystemobject").GetFolder("C:\")
For Each oFile In oFolder.Files
    If InStr(1, oFile.Name, ".pdf", vbTextCompare) Then MsgBox oFile.Path Else: Next oFile
...
Next oFile
End Sub

Naturally the above will throw up a "Next w/o For" error. Is there anyway to have a oneline if that can contain a next in the else? Or code that effectively does the same.

Reason being, I have a fair number of nested if statements that come after the above in the example.

 

[Norie]

What does the rest of the code do?

 

[GlennUK]

Your structure needs to be like this:

 Dim oFile As Object, oFolder As Object
 
Set oFolder = CreateObject("scripting.filesystemobject").GetFolder("C:\")
For Each oFile In oFolder.Files
    If InStr(1, oFile.Name, ".pdf", vbTextCompare) Then 
        MsgBox oFile.Path 
    ElseIf next test Then
        MsgBox something else
    ElseIf next next test Then
        MsgBox another something else
    End If
Next oFile
End Sub

 

[adam087]

There might be a better way but I do it like this:

Option Explicit
 
Private Sub Example()
 
Dim r As Range, SomethingToTest As Boolean
 
For Each r In ActiveSheet
 
    If Not SomethingToTest Then GoTo skiPPy
    'do whatever you'd do
 
skiPPy:
Next r
 
End Sub

Regards
Adam

 

[jaybee3]

What does the rest of the code do?

Parses the pdf and gathers various fields from it, testing to see if they are in the correct places/contained at all.

Structure...

As suspected, it has to follow that format. Cheers.

...GoTo

Hmm that might be a viable solution actually.

 

[CharlesChuckieCharles]

Remove Else and put the EndIf above the Next oFile

you'll just have to nest them a bit more

or move your tests into their own function

there is no Loop function for "For Each"

 

[Norie]

Are you going to do all the parsing in the loop?

Why not create a function/sub to do that?

You could pass the filename to that, have it do all the parsing and then return to the main sub to continue with the loop.

PS You really should avoid using Goto.

 

[adam087]

Are you going to do all the parsing in the loop?

Why not create a function/sub to do that?

You could pass the filename to that, have it do all the parsing and then return to the main sub to continue with the loop.

PS You really should avoid using Goto.

You're almost certainly correct - but for my own interest why is GoTo a bad thing? Thanks.

Adam

 

[Norie]

Adam

Try searching for 'spaghetti code'.

 

[jaybee3]

Stuck to standard code structure and put a handful of my checks in some other subs/functions as suggested. The problem I was having was with the nesting...visually. Since I like it all idented, I was having to scroll across the page to read the next line.

Basically, it loops thru the files, checks the information's there, takes the information, looks through another folder for each of the details in the previous files and does further checks...before reconciling it. Rinse and repeat for further files before moving onto the next .pdf in this example.