Missing an if issue

[sassriverrat]

I messed up an if here and was hoping someone could check it for me

Private Sub Save_As()'Creates the SaveAs "Current Voyage" on the Noon Sheet


    Dim Path1 As String
    Dim Path2 As String
    Dim Path3 As String
    Dim myfilename As String
    Dim fpathname As String
    Dim resp As Integer
    Dim name As String
    
    With Worksheets("Notes")
    Path1 = .Range("O16")
    name = .Range("N4")
    Path2 = .Range("O18")
    Path3 = .Range("U16")
    End With
    
    myfilename = Path2
    fpathname = Environ("Userprofile") & "\" & Path1 & "\" & Path3 & "\"
    
    If ActiveWorkbook.name = "Master Voyage Report.xlsm" Then
        ActiveSheet.EnableCalculation = False
    
        resp = MsgBox("You are trying to save the " & myfilename & " to:" & vbCrLf & fpathname & myfilename & ".xlsm", vbYesNo, name)
        If resp = vbYes Then
            If Dir(fpathname, vbDirectory) = "" Then MkDir (fpathname)
                Else: ActiveWorkbook.SaveAs Filename:=fpathname & myfilename & ".xlsm", FileFormat:=xlOpenXMLWorkbookMacroEnabled
            End If
                'Application Closer
            If Workbooks.Count > 1 Then
                ActiveWorkbook.Close
            Else: Application.Quit
            End If
        ElseIf vbNo Then
            Exit Sub
        ElseIf vbCancel Then
            Exit Sub
        End If
    ElseIf ActiveWorkbook.name = myfilename Then
        ActiveWorkbook.Save
        'Application Closer
                If Workbooks.Count > 1 Then
                    ActiveWorkbook.Close
                Else: Application.Quit
                End If
    Else: ActiveWorkbook.Save
        'Application Closer
                If Workbooks.Count > 1 Then
                    ActiveWorkbook.Close
                Else: Application.Quit
                End If
    End If
End Sub

 

[sassriverrat]

It's the other way round
Len=0
Dir=""
Not sure if there is any benefit to one method over the other.

Interesting....so I just pulled a small section out of my code. It error'd earlier, kicking me because I had = 0 instead of as you see it.

resp = MsgBox("You are trying to save the " & myfilename & " to:" & vbCrLf & fpathname & myfilename & ".xlsm", vbYesNo, name)
        If resp = vbYes Then
            If Dir(fpathname, vbDirectory) = "" Then
                MkDir (fpathname)
                ActiveWorkbook.SaveAs Filename:=fpathname & myfilename & ".xlsm", FileFormat:=xlOpenXMLWorkbookMacroEnabled
            Else
                ActiveWorkbook.SaveAs Filename:=fpathname & myfilename & ".xlsm", FileFormat:=xlOpenXMLWorkbookMacroEnabled
            End If

 

[sassriverrat]

Also, what would stop me if I had a
Kill Filename
from allowing me to delete a file? Debug says permission denied?

 

[MARK858]

Also, what would stop me if I had a
Kill Filename
from allowing me to delete a file? Debug says permission denied?

Is the file still open?

 

[sassriverrat]

Yes. It didn’t even save (I checked the appropriate folder and it didn’t run the save-as)

 

[MARK858]

You can't kill a file that is open.

 

[sassriverrat]

It’s only open because the saveas code didn’t seem to work as it should....

 

[MARK858]

No problem, was just answering your question on what would stop you killing the file.
Are you still having issues with the save? If yes I will try and look at it when I get in but I am working for 12 hours today so might not feel like it then.

 

[sassriverrat]

seems to be working now. It's particularly odd that it's inconsistent...i couldn't replicate the problem. I appreciate you looking into it for me!