Items not being added to dictionary

[BarryL]

Hi All,

I have the below which is supposed to be adding a range of text values to a dictionary however when I debug.print it nothing is being added. list1 is defined as a variant.

   Set d = CreateObject("scripting.dictionary")
list1 = ThisWorkbook.Sheets("Summary").Range("A7:A22").Value
For e = LBound(list1) To UBound(list1)
On Error Resume Next
    d.Add list1(e, 1), 1
    Debug.Print d.Item(e)
Next e

 

[JackDanIce]

Your code is mapping a value of 1 to each text key value, is this intentional? Try following:

    Dim list1() As Variant
    Set d = CreateObject("scripting.dictionary")
    list1 = ThisWorkbook.Sheets("Summary").Range("A7:A22").Value
    For e = LBound(list1, 1) To UBound(list1, 1)
        d.add list1(e, 1), 1
        Debug.Print d.Item(list1(e, 1))
    Next e

 

[RoryA]

Unless A7:A22 contains the numbers 1, 2, 3 etc you are trying to refer to keys that don't exist. What exactly are you trying to output - the keys, or the items (which are all 1)? Assuming you want to see the keys, you could use this:

 Set d = CreateObject("scripting.dictionary")
list1 = ThisWorkbook.Sheets("Summary").Range("A7:A22").Value
For e = LBound(list1) To UBound(list1)
    d(list1(e, 1)) = 1
    Debug.Print d.keys()(e - 1)
Next e