If cell is > 0

[288enzo]

I can't for the life of me figure out why this isn't working. It seems so straight forward, what am I missing?

This is what I have:

s.xlsx
	E			H
204	Complete
205	Complete
206	Complete
207	N/A
208	Complete
209	Complete
210	Complete
211	N/A
212	Complete
213	5
214	Complete
215	Complete
216	Complete
217	Complete
218	Complete
219	Complete
s

I'm trying to identify the cells in column E that are greater than 0.

When I run the code, all cells return True.

Sub test()
    lr = Cells(Rows.Count, 1).End(xlUp).Row
    For y = 2 To lr
        If Rows(y).Hidden = False And Range("E" & y) > 0 Then Range("H" & y) = True
    Next y
End Sub

 

[Micron]

None of them are blank so all are greater than 0? I have to admit that it's not intuitive that the default for that comparison works that way.
What exactly are you trying to do? I only see 1 cell with a number and none of the rest are blank. Perhaps you want to only compare numbers? Then maybe

If Rows(y).Hidden = False And Application.WorksheetFunction.IsNumber(Range("E" & y)) And Range("E" & y) > 0 Then Range("H" & y) = True

That will not fix cells that were numbers greater than 0 but later become something else.

 

[288enzo]

None of them are blank so all are greater than 0? I have to admit that it's not intuitive that the default for that comparison works that way.
What exactly are you trying to do? I only see 1 cell with a number and none of the rest are blank. Perhaps you want to only compare numbers? Then maybe

If Rows(y).Hidden = False And Application.WorksheetFunction.IsNumber(Range("E" & y)) And Range("E" & y) > 0 Then Range("H" & y) = True

That will not fix cells that were numbers greater than 0 but later become something else.

Thank you, turns out I was on the right track before your response with:

Sub test()
    lr = Cells(Rows.Count, 1).End(xlUp).Row
    For y = 2 To lr
        If Rows(y).Hidden = False And IsNumber(Range("E" & y)) Then Range("H" & y) = True
    Next y
End Sub

I had forgot about Application.WorksheetFunction

 

[Micron]

Glad I could help & thanks for the recognition.

 

[offthelip]

there is a specific VBA function that does the same thing: ISNUMERIC

 

[Micron]

IsNumeric returns true if the value can be converted to a number data type. It doesn't mean it's a number data type, yes?

IsNumeric("12") is True
application.worksheetfunction.isnumber("12") returns False

Most cells had values that could end up being interpreted as strings so I suggested what I thought would be the least problematic. I'd still use IsNumber unless someone has a reason why not to do that.