disable menu item - why doesn't this code work?

[Nick147]

This code doesn't work for some reason. I get a a runtime error "Invalid procedure or argument"

Sub disablemenutitems()
With Application.commandbars("Proposal").Controls
.Item("Enter/Edit Invoice Data...").Enabled = False
End With
End Sub

Sub enablemenuitems()
With Application.commandbars("Proposal").Controls
.Item("Enter/Edit Invoice Data...").Enabled = True
End With
End Sub

These two subs work fine if I use "File" in place of "Proposal" and "Print..." in place of "Enter/Edit Invoice Data...".

NL

 

[Nick147]

"Proposal" is disabled.

 

[Nick147]

"Proposal" is disabled.

 

[TommyGun]

Okay, then re-enable it by running that code with TRUE. Now try this code...

Sub Test3()
Application.CommandBars(1).Controls("Proposal").Controls("Edit/Enter Invoice Data...").Enabled = False
End Sub

What happens now?

 

[Nick147]

I get the same run-time error.

 

[TommyGun]

Okay, then the control "Edit/Enter Invoice Data..." does not exist inside your "Proposal" menu. I have tested this on XL 97 & XL 2003 and it works fine for me.

 

[Nick147]

What do you mean it doesn't "exist"? When I select "Proposal" I can see "Enter/Edit Invoice Data..." and when I select "Enter/Edit Invoice Data..." the .Onaction (see code) shows the "invoicedata" userform just like it suppose to.

 

[TommyGun]

Don't know why this is necessary, but this should do the trick. I'll need to look into this further at a later time.

Sub Test3() 
Application.CommandBars(1).Controls("Proposal").Controls(2).Enabled = False
End Sub

 

[Nick147]

YES! that worked. I think it may have had something to do with me using the same "Menuitem" variable to create all of my new menu items. I was just starting to follow up on this just before I got you last reply.

Thanks so much for you help.
NL