Dir Do Until Loop not working

[Jetx227]

Hi guys! I have this for loop iterating through each folder in a file path, then it goes into the folder and gets the names of the files. Only problem is that while it should be getting the name of every file in each folder, it only gets the name of the first file. So I though a Do Until loop would solve the issue, but it didn't do anything. Any help would be great, thanks!

For Each objFolder In objFolders
   FileName = Dir(FilePath & "\" & objFolder.Name & "\" & objFolder.Name & "*")
   Do Until FileName = ""
      'Some Commands that have to do with the filename
      FileName = Dir()
   Loop

Note, if this is normally supposed to work (because I took this off some website [codevba.com/office/loop_files_in_folder.htm] ), is it possible that commands that I use in the Do Until loop would interfere with it? Thanks

 

[Fluff]

You could try

Sub looper()
    Dim objFSO As Object
    Dim objFolders As Object
    Dim objFolder As Object
    Dim objFile As Variant
    Dim strDirectory As String


    With Application.FileDialog(4)
        .InitialFileName = Application.DefaultFilePath & "\"
        .Title = "Select Folder"
        .Show
        If .SelectedItems.Count = 0 Then
            Exit Sub
        End If
        strDirectory = .SelectedItems(1)
    End With
    
    Set objFSO = CreateObject("Scripting.FileSystemObject")
    Set objFolders = objFSO.GetFolder(strDirectory).SubFolders
    
   For Each objFolder In objFolders
      For Each objFile In objFolder.files
         'Some Commands that have to do with the filename
         MsgBox objFile.Name
      
      Next objFile
   Next objFolder
End Sub

 

[Jetx227]

You could try

Sub looper()
    Dim objFSO As Object
    Dim objFolders As Object
    Dim objFolder As Object
    Dim objFile As Variant
    Dim strDirectory As String


    With Application.FileDialog(4)
        .InitialFileName = Application.DefaultFilePath & "\"
        .Title = "Select Folder"
        .Show
        If .SelectedItems.Count = 0 Then
            Exit Sub
        End If
        strDirectory = .SelectedItems(1)
    End With
    
    Set objFSO = CreateObject("Scripting.FileSystemObject")
    Set objFolders = objFSO.GetFolder(strDirectory).SubFolders
    
   For Each objFolder In objFolders
      For Each objFile In objFolder.files
         'Some Commands that have to do with the filename
         MsgBox objFile.Name
      
      Next objFile
   Next objFolder
End Sub

This almost worked. It just pulled the first file as many times as there are files in the folder. (So if I have a folder with 3 files, it'll pull the first file 3 times).

 

[Fluff]

It doesn't do that for me, so not sure what is happening.

 

[Jetx227]

It doesn't do that for me, so not sure what is happening.

I think its still because of adding that file and removing it, Im not sure why but I think it just messes with the file order or something

 

[Jetx227]

It doesn't do that for me, so not sure what is happening.

Hi Fluff,
I just realized that when I tested your code, I forgot to change one line of my commands to call objFile and not what I had previously been using, which is what caused the issue of only pulling the first file. So your for loop works perfect! Thank you very much for your help

 

[Fluff]

Glad you figured it out & thanks for the feedback