"Compile error: Expected: expression"

[mxaho]

Hi,

This message is coming up and I can't figure out what's wrong, could someone please assist?

qurl = "https://trader.di.se/index.php/stock_history?" & Ticker &
"&startdate=" & MonthName(Month(sdate), True) &
"+" & Day(sdate) & "+" & Year(sdate) & "&enddate=" & Monthname(Month(edate), True) &
"+" & Day(edate) & "+" & Year(edate)

I'm trying to get data from the web to excel.

Thanks in advance!

 

[mxaho]

And this is the full qurl I'm trying to insert : https://trader.di.se/index.php/stoc...d=285&startDate=2017-05-22&endDate=2018-05-22

 

[jproffer]

Did you try "msgboxing" each variable (sdate, edate, etc) at runtime to make sure it's formatted the way it should be for the URL?

and just to check, this is what I'm seeing for a URL (generically speaking)...

https://trader.di.se/index.php/stock_history?GOOGL&startdate=May+21+2018&enddate=May+22+2018

and BTW, when I try that link it goes to a blank page...forbidden. Could that be the problem? It could be that you are "signing in" elsewhere in the code, just checking everything I can think of....

EDIT: You're putting "+" symbols into your URL and I didn't see any in the one you posted.

 

[jproffer]

You could create string variables to hold the entire date, formatted as you need it and use that in your line of code instead of MonthName....Day...Year. Just another idea.

 

[mxaho]

You could create string variables to hold the entire date, formatted as you need it and use that in your line of code instead of MonthName....Day...Year. Just another idea.

Thans for your answer.

I'm brand new to VBA so that's the big problem haha... The qurl I entered works for me, strange it doens't work for you. As you mentioned, I see that the "+" is wrong (I tried to look at Youtube, but it was another qurl there).

How do I enter a date like "2018-05-22" in the best way in VBA?

 

[mxaho]

I now tested like this. First the link is https://trader.di.se/index.php/stock_history?instrumentid=73&startDate=2017-05-22&endDate=2018-05-22

qurl = "https://trader.di.se/index.php/stock_history?instrumentid=" & ticker & ""
"&startDate=" & Year(sdate) & "-" & Month(sdate) & "-" & Day(sdate) &
"&endDate=" & Year(edate) & "-" & Month(edate) & "-" & Day(edate)"

I still got the same error

 

[jproffer]

I would do something like:

Dim sdate As String
Dim MyStartDate as String

    sdate = "may 22, 2018"
    
    
   MyStartDate= Format(sdate, "yyyy") & "-" & Format(sdate, "mm") & "-" Format(sdate, "dd")

And then something very similar for MyEndDate...and then:

qurl = "https://trader.di.se/index.php/stock_history?instrumentid=" & ticker & "&startDate=" & MyStartDate & "&endDate=" & MyEndDate