Checking all textbox controls on userform for null value

[jeffreybrown]

Need a little help here...got stuck.

I'm checking all the textboxes on a userform for a null value which is working fine, but need to now exit the sub if one or more are null.

The code below gives the name of the textbox that is null, but even if everything is not null I still get the msgbox.

Any thoughts?

    For Each ctrl In UserForm1.Controls
        If TypeName(ctrl) = "TextBox" Then
            If ctrl.Text = "" Then
                txtAddress = txtAddress & ctrl.Name & " is empty" & vbNewLine
            End If
        End If
    Next ctrl
MsgBox txtAddress, vbOKOnly, "Checking textboxes for no entry"

 

[Andrew Poulsom]

Maybe try:

    For Each ctrl In UserForm1.Controls
        If TypeName(ctrl) = "TextBox" Then
            If ctrl.Text = "" Then
                txtAddress = txtAddress & ctrl.Name & " is empty" & vbNewLine
                Exit For
            End If
        End If
    Next ctrl
    If txtAddress <> "" Then
        MsgBox txtAddress, vbOKOnly, "Checking textboxes for no entry"
    End If

 

[jeffreybrown]

Hi Andrew and thanks for the help,

That doesn't seem to do it. I have multiple textboxes on userform1.

I filled in one textbox selected the command button to enter data to the worksheet and I get a msgbox saying one textbox is empty (more than one are actually empty), but then it still writes the info from the one filled out textbox to the worksheet.

I would like it to list all textboxes which are empty and then exit the sub or if all textboxes are not empty then for the entered values to be written to the worksheet.

 

[Andrew Poulsom]

You haven't posted any code that transfers data to a worksheet, but maybe what you want is:

    For Each ctrl In UserForm1.Controls
        If TypeName(ctrl) = "TextBox" Then
            If ctrl.Text = "" Then
                txtAddress = txtAddress & ctrl.Name & " is empty" & vbNewLine
            End If
        End If
    Next ctrl
    If txtAddress <> "" Then
        MsgBox txtAddress, vbOKOnly, "Checking textboxes for no entry"
        Exit Sub
    End If

 

[jeffreybrown]

That's perfect...thank you Andrew