Worksheet change is crashing excel

[rikvny02]

For what reason is the below worksheet change crashing excel. this can easily be done with a formula however, i have a double click function that does not carry the formula.

Private Sub Worksheet_Change(ByVal Target As Range)
Dim LastRow As Long
Dim G As Long
LastRow = Range("A" & Rows.Count).End(xlUp).Row
For G = 2 To LastRow
If Range("E" & G).Value = "99" Then
Range("G" & G).Value = "99"
ElseIf Range("E" & G).Value = "95" Then
Range("G" & G).Value = "95"
ElseIf Range("E" & G).Value = "991" Then
Range("G" & G).Value = "991"
ElseIf Range("E" & G).Value = "71" Then
Range("G" & G).Value = "71"
ElseIf Range("E" & G).Value = "40" Then
Range("G" & G).Value = "40"

End If
Next G
End Sub

 

[Joe4]

The issue with "Worksheet_Change" event procedures is that they are triggered whenever a change is made. So if you are not careful, and your code is making changes, it could get caught up in an infinite loop. So you need to temporarily disable events while the changes are being made by your code.

You can also simplify the code a little, like this:

Private Sub Worksheet_Change(ByVal Target As Range)

    Dim LastRow As Long
    Dim G As Long

    Application.EnableEvents = False

    LastRow = Range("A" & Rows.Count).End(xlUp).Row
    For G = 2 To LastRow
        Select Case Range("E" & G).Value
            Case "99", "95", "991", "71", "40"
                Range("G" & G).Value = Range("E" & G).Value
        End Select
    Next G
   
    Application.EnableEvents = True
   
End Sub

Also note that people typically limit when the code runs depending on which cells are being updated.
Right now, you have your code running against ALL rows any time any data change is made anywhere on the sheet.

 

[rikvny02]

The issue with "Worksheet_Change" event procedures is that they are triggered whenever a change is made. So if you are not careful, and your code is making changes, it could get caught up in an infinite loop. So you need to temporarily disable events while the changes are being made by your code.

You can also simplify the code a little, like this:

Private Sub Worksheet_Change(ByVal Target As Range)

    Dim LastRow As Long
    Dim G As Long

    Application.EnableEvents = False

    LastRow = Range("A" & Rows.Count).End(xlUp).Row
    For G = 2 To LastRow
        Select Case Range("E" & G).Value
            Case "99", "95", "991", "71", "40"
                Range("G" & G).Value = Range("E" & G).Value
        End Select
    Next G
 
    Application.EnableEvents = True
 
End Sub

Also note that people typically limit when the code runs depending on which cells are being updated.
Right now, you

The issue with "Worksheet_Change" event procedures is that they are triggered whenever a change is made. So if you are not careful, and your code is making changes, it could get caught up in an infinite loop. So you need to temporarily disable events while the changes are being made by your code.

You can also simplify the code a little, like this:

Private Sub Worksheet_Change(ByVal Target As Range)

    Dim LastRow As Long
    Dim G As Long

    Application.EnableEvents = False

    LastRow = Range("A" & Rows.Count).End(xlUp).Row
    For G = 2 To LastRow
        Select Case Range("E" & G).Value
            Case "99", "95", "991", "71", "40"
                Range("G" & G).Value = Range("E" & G).Value
        End Select
    Next G
 
    Application.EnableEvents = True
 
End Sub

Also note that people typically limit when the code runs depending on which cells are being updated.
Right now, you have your code running against ALL rows any time any data change is made anywhere on the sheet.

have your code running against ALL rows any time any data change is made anywhere on th

The issue with "Worksheet_Change" event procedures is that they are triggered whenever a change is made. So if you are not careful, and your code is making changes, it could get caught up in an infinite loop. So you need to temporarily disable events while the changes are being made by your code.

You can also simplify the code a little, like this:

Private Sub Worksheet_Change(ByVal Target As Range)

    Dim LastRow As Long
    Dim G As Long

    Application.EnableEvents = False

    LastRow = Range("A" & Rows.Count).End(xlUp).Row
    For G = 2 To LastRow
        Select Case Range("E" & G).Value
            Case "99", "95", "991", "71", "40"
                Range("G" & G).Value = Range("E" & G).Value
        End Select
    Next G
  
    Application.EnableEvents = True
  
End Sub

Also note that people typically limit when the code runs depending on which cells are being updated.
Right now, you have your code running against ALL rows any time any data change is made anywhere on the sheet.

When using your simplified version everything works very smooth. Thanks for your help

 

[Joe4]

You are welcome.
Glad I was able to help!

I hope it makes sense. That is something very important to remember when using Worksheet_Change event procedure, so you don't get caught up in an infinite loop and crash your system.

 

[FerdieB]

You are welcome.
Glad I was able to help!

I hope it makes sense. That is something very important to remember when using Worksheet_Change event procedure, so you don't get caught up in an infinite loop and crash your system.

This is a life-saver for me! Thanks for your contribution!