VBA Warning pops up before macro runs

[rplohocky]

Hello,
The code below works but only after the warning pops up. I get a critical warning pop up that says "No Such Template". Can anyone see why the warning pops up first then actually does what the macro is supposed to do?

<code>
Sub OL()



Dim objOL As Outlook.Application, msg As MailItem, p, i
Set objOL = CreateObject("Outlook.Application")

On Error Resume Next
For i = 1 To Range("h" & rows.Count).End(xlUp).Row
p = "C:\Users\RPlohocky\Desktop\Macro Projects\testing workbooks" & Cells(i, "h") & ".msg" ' template path
Set msg = objOL.CreateItemFromTemplate(p)

If Err.Number > 0 Then MsgBox "No such template", vbCritical, Cells(i, "h")


msg.Subject = "Driver Add Request Workflow# " & [d2] & " Fleet/Unit " & [e2] & " / " & [f2]
msg.Display
' msg.Send

Next
Set msg = Nothing
Set objOL = Nothing

End Sub
</code>

 

[gallen]

You use on error resume next which can be troublesome.

There must be an error in these lines:

[COLOR=#574123][FONT=monospace]For i = 1 To Range("h" & rows.Count).End(xlUp).Row[/FONT][/COLOR]
[COLOR=#574123][FONT=monospace]p = "C:\Users\RPlohocky\Desktop\Macro Projects\testing workbooks" & Cells(i, "h") & ".msg" ' template path[/FONT][/COLOR]
[COLOR=#574123][FONT=monospace]Set msg = objOL.CreateItemFromTemplate(p)[/FONT][/COLOR]

Because your error number must be greater than 0 as your message always deisplays:

[COLOR=#ff0000][FONT=monospace][/FONT][FONT=monospace][B]If Err.Number > 0[/B][/FONT][/COLOR][COLOR=#574123][FONT=monospace] Then MsgBox "No such template", vbCritical, Cells(i, "h")[/FONT][/COLOR]

If you remove the 'On Error Resume Next' line, this will tell you which line is causing the error as the code execution will stop