VBA Vlookup using Array

[Guinaba]

Hi guys,

I'm trying to use vlookup within array to make the code runs faster, in the code below the .Cells(ii, 1).Formula with vlookup is working ok, however the other two lines don't. Any suggestion? These two lines are doing the same thing, just trying different approaches.

.Cells(ii, 1).value = Application.VLookup(ArrCalc(ii, 1), ArrVlkup1, 2, False)

ArrResult1(ii) = Application.VLookup(ArrCalc(ii, 1), ArrVlkup1, 2, False)

Sub TPRP_Refresh()

Application.ScreenUpdating = False

'Loop to calculate the formulas

Dim RangeCalc As Range

Set RangeCalc = Sheets("TPRP").Range("A1").CurrentRegion

Dim ArrCalc() As Variant

Dim RangeVlkup1 As Range

Set RangeVlkup1 = Sheets("criteria").Range("A2").CurrentRegion

Dim ArrVlkup1() As Variant, ArrResult(500) As Variant

ArrVlkup1 = RangeVlkup1
ArrCalc = RangeCalc
 
Dim ii As Long

For ii = 5 To UBound(ArrCalc)

.Cells(ii, 1).Formula = "VLOOKUP(H" & ii & ",criteria!A:B,2,FALSE))" ‘This method works

.Cells(ii, 1).value = Application.VLookup(ArrCalc(ii, 1), ArrVlkup1, 2, False) ‘This method doesn’t work

ArrResult1(ii) = Application.VLookup(ArrCalc(ii, 1), ArrVlkup1, 2, False) ‘This method doesn’t work

Next ii

ii = ii + 1

End With

Application.ScreenUpdating = True

End sub

 

[Alex Blakenburg]

That is not how a vlookup works.
The 2nd parameter needs a range of cells, it can't use a VBA Array.

If you want to make your code run faster, you could try asking a question on this forum with an XL2BBs of your main data and you lookup data and ask specifically for a dictionary solution.

VLOOKUP (lookup_value, table_array, col_index_num, [range_lookup])
Ref: Microsoft Doc - VLOOKUP function

 

[Marcelo Branco]

That is not how a vlookup works.
The 2nd parameter needs a range of cells, it can't use a VBA Array

hmm...i'm not so sure

This worked for me

Pasta1
	B	C
1	Text	Value
2	a	10
3	b	20
4	c	30
Plan12

Sub aTest()
    Dim vData As Variant, s As String
    Dim myVar As Long
    
    vData = Range("B2:C4").Value
    s = "b"
    myVar = Application.VLookup(s, vData, 2, 0)
    MsgBox myVar
End Sub

M.

 

[Peter_SSs]

I agree with Marcelo.
However, I am having difficulty advising the OP re that code as it is incomplete and not valid code as it stands.

 

[Alex Blakenburg]

Thanks @Marcelo Branco, Learn something new everyday. ?
@Peter_SSs, do you know if it would be faster than using a dictionary ?

 

[Marcelo Branco]

Alex,

You're welcome. I also learn, every day, new things in this forum.

M.

 

[Peter_SSs]

@Peter_SSs, do you know if it would be faster than using a dictionary ?

I don't know because I don't really know what the OP has or exactly what is being attempted.

 

[Marcelo Branco]

Just a guess. I would bet on that known VLOOKUP issue, Text vs. Number, i.e., one of the values is a number and the other is text

M.

 

[Guinaba]

Thanks guys! @Marcelo Branco you are right! That was my mistake, I was using the incorrect col. to look for the value in the another array. I have corrected the code below and now it is working.

Sub TPRP_Refresh()

    With Sheets("TPRP")
            
      'Loop to calculate the formulas
       Dim ArrCalc As Variant, ArrVlkup1 As Variant, ArrVlkup2 As Variant
       Dim LastRow As Long
       ArrCalc = Sheets("TPRP").Range("A1").CurrentRegion
       LastRow = Sheets("criteria").Cells(.Rows.Count, "A").End(xlUp).Row
       ArrVlkup1 = Sheets("criteria").Range("A2:B" & LastRow)
       Dim ii As Long
               
       For ii = 5 To UBound(ArrCalc)
          .Cells(ii, 1).Value = Application.VLookup(ArrCalc(ii, 8), ArrVlkup1, 2, False)
         Next ii
       ii = ii + 1
    End With
      
    Erase ArrCalc, ArrVlkup1
     
End Sub

 

[Guinaba]

Hi @Marcelo Branco,

Just one question, forgot to ask you before, what is the difference when you declare an array with () or not. in your code you are not using. I did the same and the code worked, if I add the ( ) the code doesn't.

For example:

Dim ArrCalc
Dim ArrCalc ()