VBA to define variable using if then

[chroniclesofdave]

I am wanting to have a outlook email address to be set based on the value of Combobox2. What i have doesn't seem to function, and i am sure it is simple but i am a little stuck. any suggestions would be great. What i have so far is:

Dim name As String
If ComboBox2.Value = "Bill" Then Set carrier = "Bill@gmail.com"
ElseIf ComboBox2.Value = "George" Then Set carrier = "George@icloud.com"
End If

 

[Joe4]

You only use the "Set" keyword when setting objects like ranges, not variables like strings, i.e.

Dim name As String
If ComboBox2.Value = "Bill" Then 
    carrier = "Bill@gmail.com"
ElseIf ComboBox2.Value = "George" Then carrier = "George@icloud.com"
End If

 

[Fluff]

You only set Objects not strings, so remove the word "Set".
Also you are declaring a variable called name, but then using a variable called carrier.

 

[chroniclesofdave]

Right, i had copied older code, what i will test in a moment is

 [FONT=Verdana]Dim name As String[/FONT]
If ComboBox2.Value = "Bill" Then name = "Bill@gmail.com"
ElseIf ComboBox2.Value = "George" Then name = "George@icloud.com" 
end if

 

[Joe4]

Best practices says not to use reserved words (names of existing functions, properties, and methods), like "name", as the name of variable, procedures, or functions.
It can cause ambiguity, confusion, errors, and/or unexpected results.

 

[Fluff]

Along with Joe4's comments, the if statement should be like

Dim Nme As String
If ComboBox2.Value = "Bill" Then
    Nme = "Bill@gmail.com"
ElseIf ComboBox2.Value = "George" Then
    Nme = "George@icloud.com"
End If