VBA to copy values from another workbook

asad

Well-known Member
Joined
Sep 9, 2008
Messages
1,434
Hi Guys,

I am trying to copy values from a closed workbook to active workbook. I have following code, but this one is not working. Any help in making it work will appreciated.
Code:
Sub CopyValues()Dim swb As Workbook, dwb As Workbook
Set dwb = ActiveWorkbook
Set swb = Workbooks.Open("S:\Leave Allocations\Leave Register.xlsm")
swb.Sheets("Emp").Range("A1:C1000").Select
Selection.Copy
dwb.Activate
ActiveWorkbook.Sheets("Emp").Range("A1:C1000").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
swb.Close




End Sub


Thanks
Asad
 

Excel Facts

How to find 2nd largest value in a column?
MAX finds the largest value. =LARGE(A:A,2) will find the second largest. =SMALL(A:A,3) will find the third smallest
Just to clarify, I intend to use this code in multiple files. So the "dwb" workbook needs to refer to the workbook I am running the code from.
 
Upvote 0
Got it right now :)
Code:
Sub CopyValues()Dim swb As Workbook, dwb As Workbook
Set dwb = ActiveWorkbook
Set swb = Workbooks.Open("S:\Leave Allocations\Leave Register.xlsm")
swb.Sheets("Emp").Select
ActiveSheet.ShowAllData
Range("A1:C1000").Select
Selection.Copy
dwb.Activate
ActiveWorkbook.Sheets("Emp").Range("A1:C1000").Select
    Selection.PasteSpecial Paste:=xlPasteValues, Operation:=xlNone, SkipBlanks _
        :=False, Transpose:=False
swb.Close




End Sub
 
Upvote 0

Forum statistics

Threads
1,223,911
Messages
6,175,329
Members
452,635
Latest member
laura12345

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top