VBA: sudden crash during macro execution

[Nelson78]

Hello everybody.

I'm managing a lot of data with a complex macro.
At a certain point, Excel stops to work.

The message is:

Microsoft Excel has stopped working
Windows is checking for a solution to a problem

I have identified the part of code where the event happens.
lrt = 4586, the event happens beetween lrt = 2000 and lrt = 3000

Any suggestion?

Dim lrt As Long
lrt = Worksheets("Alpha").Cells(Rows.Count, "A").End(xlUp).Row

For Each cellnum In Range("BF2:BH" & lrt)
If cellnum.Offset(0, 3).Value = "Z" Then
     cellnum.Value = "0" & Trim(Str(cellnum))
  End If

Next

 

[Joe4]

What exactly are you trying to accomplish with this line?

     cellnum.Value = "0" & Trim(Str(cellnum))

It looks a little odd to me.

Also, suppressing calculations and screen updates while your code is running may help.
Place these lines at the beginning of your code:

    Application.ScreenUpdating = False
    Application.Calculation = xlCalculationManual

and then these at the end of your code:

    Application.Calculation = xlCalculationAutomatic
    Application.ScreenUpdating = True

 

[Nelson78]

What exactly are you trying to accomplish with this line?

     cellnum.Value = "0" & Trim(Str(cellnum))

It looks a little odd to me.

Also, suppressing calculations and screen updates while your code is running may help.
Place these lines at the beginning of your code:

    Application.ScreenUpdating = False
    Application.Calculation = xlCalculationManual

and then these at the end of your code:

    Application.Calculation = xlCalculationAutomatic
    Application.ScreenUpdating = True

Same result.

With

cellnum.Value = "0" & Trim(Str(cellnum))

i had to add a 0 in front of telephone numbers (I receive a source without 0, but for landline it is needed).

 

[Joe4]

Without knowing the structure/size of your data, the rest of your VBA code, and the processing power of your computer, it is tough to say.
It looks like you are running out of resources. That part of the code you posted should not, by itself, cause a typical computer to crash.

It could be something like:
- a corrupt install of Excel
- corrupt workbook
- bad data
- inefficient VBA code
- too much other stuff going on that is hogging all the resources (in VBA or dependent formulas on the workbook)
- a computer without much processing power

 

[Nelson78]

Without knowing the structure/size of your data, the rest of your VBA code, and the processing power of your computer, it is tough to say.
It looks like you are running out of resources. That part of the code you posted should not, by itself, cause a typical computer to crash.

It could be something like:
- a corrupt install of Excel
- corrupt workbook
- bad data
- inefficient VBA code
- too much other stuff going on that is hogging all the resources (in VBA or dependent formulas on the workbook)
- a computer without much processing power

Ok, the solution was inefficient VBA code.

Thank's.