VBA - Struggling to work out why my 'collection' isn't populating

tbablue

Active Member
Joined
Apr 29, 2007
Messages
488
Office Version
  1. 365
Platform
  1. Windows
Hi Forum,

My VBA is attempting to take copies of a table 'By_Reporting_Period', filtering on values in a field [Reporting_Period_Date], put that in a new new worksheet, before doing the same with the next filtered value in the same tablefield 'By_Reporting_Period[Reporting_Period_Date]'; essentially replicating the table on numerous sheets with every table broken out by the filtered values in [Reporting_Period_Date].

I'm struggling to work out why my collection, 'uniqueValues', remains empty and therefore errors on line 'For Each cell In uniqueValues'.
The data being passed is dates - every field is uniform - there are no blanks.

Any ideas? My code is shown in its entirety below.

......


Sub CopyTableByUniqueDates()

Dim wsSource As Worksheet
Dim tbl As ListObject
Dim keyColumn As Range
Dim cell As Range
Dim uniqueValues As Collection
Dim newWs As Worksheet
Dim filterFieldIndex As Integer

Set wsSource = ThisWorkbook.Sheets("Parameter_Sheet")
Set tbl = wsSource.ListObjects("By_Reporting_Period")
Set keyColumn = tbl.ListColumns("Reporting_Period_Date").DataBodyRange
filterFieldIndex = tbl.ListColumns("Reporting_Period_Date").Index
Set uniqueValues = New Collection

' Collect unique values
On Error Resume Next
For Each cell In keyColumn
uniqueValues.Add cell.Value, CStr(cell.Value)
Next cell
On Error GoTo 0

' Filter and copy data for each unique value

For Each cell In uniqueValues
Set newWs = Sheets.Add(After:=Sheets(Sheets.Count))
newWs.Name = Format(cell, "yyyy-mm-dd")

tbl.Range.AutoFilter Field:=filterFieldIndex, Criteria1:=cell
tbl.Range.SpecialCells(xlCellTypeVisible).Copy Destination:=newWs.Range("A1")
tbl.Range.AutoFilter Field:=filterFieldIndex
Next cell
On Error GoTo 0

End Sub
 

Excel Facts

Copy formula down without changing references
If you have =SUM(F2:F49) in F50; type Alt+' in F51 to copy =SUM(F2:F49) to F51, leaving the formula in edit mode. Change SUM to COUNT.
Your collection doesn't contain ranges, it contains values.
 
Upvote 0
Solution
TY.

You made me realise that there was a better way to do this. I really appreciate you taking the time to respond. Most grateful.

I've marked your reply as a solution. Thanks gain.
 
Upvote 0

Forum statistics

Threads
1,223,888
Messages
6,175,208
Members
452,618
Latest member
Tam84

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top