VBA not running

neasds

New Member
Joined
Nov 16, 2009
Messages
45
For some reason this VBA does not run when I insert it into the module? Any suggestions?

Sub vba_combine_workbooks ( )

Dim Path As String

Dim Filename As String

Dim Sheet As Worksheet

Path = “C:\Users\Dwight\Documents\"

Filename = Dir (Path & “*.cvs”)

Do While Filename <> “”

Workbooks.Open Filename:=Path & Filename, ReadOnly:=True

For Each Sheet In ActiveWorkbook.Sheets

Sheet.Copy After:=thisWorkbook.Sheets(1)

Next Sheet

Workbooks (Filename).Close

Filename = Dir ()

Loop

End Sub
 

Excel Facts

Format cells as currency
Select range and press Ctrl+Shift+4 to format cells as currency. (Shift 4 is the $ sign).
Two things:

It is generally advised NOT to use reserved words (words of existing Excel/VBA functions, methods, properties, objects, etc) as the name of your variables.
So I would prefix all of these variables with the word "My":
VBA Code:
Dim Path As String

Dim Filename As String

Dim Sheet As Worksheet

Secondly, shouldn't this:
VBA Code:
Filename = Dir (Path & “*.cvs”)
actually be this?
VBA Code:
Filename = Dir (Path & "*.csv")
(straight double-quotes and "csv" instead of "cvs").
 
Upvote 0

Forum statistics

Threads
1,223,239
Messages
6,170,947
Members
452,368
Latest member
jayp2104

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top