VBA Macro to select/open a file

[ummjay]

Hi! I am trying to create a vba macro to select a file, then open, and use that file to add in an empty column (between B and C).

I am able to get it, so I can select the file, but not getting it to work to use that file and open it.

Any ideas what I'm doing wrong?

Sub CopyWorkbook()

Dim NewFN As Workbook
Dim curWorkbook As Workbook
'
'-----------------------------------------------------------'
'   Request New Excel File
'
    NewFFN = Application.GetOpenFilename(Title:="Please Select File")
    If NewFFN = False Then
        MsgBox "Macro Terminated Due to No File Selected"
        Exit Sub
        Else
            Workbooks.Open Filename:=NewFFN
    End If
    'Set NewFN = ActiveWorkbook
'
'-----------------------------------------------------------

Application.Calculation = xlCalculationAutomatic
                 
                              
Workbooks.Open NewFFN
'With Workbooks.Open(NewFN)
'CloseThisWorkbook
MsgBox "No valid file name was supplied.", _
vbCritical, "Can't rename"


End Sub

 

[rollis13]

This is the minimum you need to open your file. From here you can go on with your project.

Option Explicit
Sub CopyWorkbook()
    Dim NewFFN  As Variant
    NewFFN = Application.GetOpenFilename(Title:="Please Select File")
    If NewFFN = False Then
        MsgBox "Macro Terminated Due to No File Selected"
        Exit Sub
    Else
        Workbooks.Open Filename:=NewFFN
    End If
    Application.Calculation = xlCalculationAutomatic   '<- may not be necessary
End Sub

 

[ummjay]

thank you , worked like a charm!

 

[rollis13]

Thanks for the positive feedback, glad having been of some help.