VBA Macro - Compile Error

Isbenji

New Member
Joined
Jul 7, 2020
Messages
17
Office Version
  1. 2016
Platform
  1. Windows
Hello, I am contacting you because I am trying to create my first VBA macro. But when I am trying to build it, I receive the following error. I am sure I am totally wrong when it comes to the code as it is the first one I am building. If any excel expert could help me to understand what is wrong in the code.

1594196730440.png


VBA Code:
VBA Code:
Private Sub CommandButton1_Click()
Dim lastRow As Long
Dim r As Long

'Find last row in column AC with data
lastRow = Cells(Rows.Count, "AC").End(xlUp).Row

'Loop through all rows in column AC, starting with row 2
For r = 2 To lastRow
'   Check to see if value is EU Country
    If Cells(r, "AC") = "Germany" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Italy" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "France" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Spain" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Portugal" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Belgium" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Netherlands" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Austria" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Croatia" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Czech Republic" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Denmark" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Estonia" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Finland" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Greece" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Hungary" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Ireland" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Latvia" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Lithuania" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Luxembourg" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Malta" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Poland" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Romania" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Slovakia" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Slovenia" Then
    Cells(r, "AD") = "EU Country"
    If Cells(r, "AC") = "Sweden" Then
    Cells(r, "AD") = "EU Country"
    'ending to see if value is EU Country
    
    Else
        Cells(r, "AD") = "Non-EU Country"

        End If
    Next r
End Sub
 

Excel Facts

Copy a format multiple times
Select a formatted range. Double-click the Format Painter (left side of Home tab). You can paste formatting multiple times. Esc to stop
You have about 20 If clauses and only one closing End If statement. It looks like you should be using ElseIf lines, or a Select Case statement:

Code:
Private Sub CommandButton1_Click()
Dim lastRow As Long
Dim r As Long

'Find last row in column AC with data
lastRow = Cells(Rows.Count, "AC").End(xlUp).Row

'Loop through all rows in column AC, starting with row 2
For r = 2 To lastRow
' Check to see if value is EU Country
Select Case Cells(r, "AC").Value
   Case "Germany", "Italy", "France", "Spain", "Portugal", "Belgium", "Netherlands", "Austria", "Croatia", "Czech Republic", "Denmark", "Estonia", "Finland", "Greece", "Hungary",  "Ireland", "Latvia", "Lithuania", "Luxembourg",  "Malta", "Poland", "Romania", "Slovakia", "Slovenia", "Sweden"
   Cells(r, "AD") = "EU Country"
'ending to see if value is EU Country

Case Else
   Cells(r, "AD") = "Non-EU Country"
End Select
Next r
End Sub
 
Last edited:
Upvote 0
Thanks a lot for cleaning the code ! I was trying to polish it but couldnt wrap my head around it. Should there be something between Value and Case because the Case "Germany"... is appearing in red


1594198789507.png
 
Upvote 0
Sorry, I missed quotation mark in front of Sweden at the end of that line.
 
Upvote 0

Forum statistics

Threads
1,223,893
Messages
6,175,240
Members
452,621
Latest member
Laura_PinksBTHFT

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top