VBA Loop

[jamescooper]

I have the following data in columns E and F.

In G via a loop I am trying to populate - I have given a few examples in the right column as to how it should look. This attempt isn't quite working.

Sub Loop1()


Dim i As Integer
Dim j As Integer


NumberRows = Application.WorksheetFunction.CountA(Columns("E:E"))


For j = 1 To NumberRows


For i = 1 To Cells(1, 6).Value


Cells(j, 7) = (Cells(j, 5) & "&page=" & i & "&count=48")


Next


Next


End Sub

[TABLE="width: 500"]
<tbody>[TR]
[TD]Apples[/TD]
[TD]3[/TD]
[TD]Apples &page=1&count=48[/TD]
[/TR]
[TR]
[TD]Pears[/TD]
[TD]2[/TD]
[TD]Apples &page=2&count=48[/TD]
[/TR]
[TR]
[TD]Apples[/TD]
[TD]2[/TD]
[TD]Apples &page=3&count=48[/TD]
[/TR]
[TR]
[TD]Grapes[/TD]
[TD]3[/TD]
[TD]Grapes &page=1&count=48[/TD]
[/TR]
[TR]
[TD]Apples[/TD]
[TD]1[/TD]
[TD][/TD]
[/TR]
[TR]
[TD]Bananas[/TD]
[TD]3[/TD]
[TD][/TD]
[/TR]
[TR]
[TD]Apples[/TD]
[TD]1[/TD]
[TD][/TD]
[/TR]
[TR]
[TD]Pears[/TD]
[TD]1[/TD]
[TD][/TD]
[/TR]
</tbody>[/TABLE]

Any help appreciated, thanks!

 

[Fluff]

Can you please explain what you are trying to do, as I cannot see any logic to your example?

 

[JackDanIce]

Try:

Sub m1()

    Dim LastRow   As Long
    Dim x         As Long
    Dim y         As Long
    Dim z         As Long: z = 1
    
    LastRow = Cells(Rows.Count, 5).End(xlUp).Row
    
    Application.ScreenUpdating = False
    
    For x = 1 To LastRow
        For y = 1 To Cells(x, 6).Value
            Cells(z, 7).Value = Cells(x, 5).Value & "&page=" & y & "&count=48"
            z = z + 1
        Next y
    Next x
    
    Application.ScreenUpdating = False

End Sub

 

[jamescooper]

Try:

Sub m1()

    Dim LastRow   As Long
    Dim x         As Long
    Dim y         As Long
    Dim z         As Long: z = 1
    
    LastRow = Cells(Rows.Count, 5).End(xlUp).Row
    
    Application.ScreenUpdating = False
    
    For x = 1 To LastRow
        For y = 1 To Cells(x, 6).Value
            Cells(z, 7).Value = Cells(x, 5).Value & "&page=" & y & "&count=48"
            z = z + 1
        Next y
    Next x
    
    Application.ScreenUpdating = False

End Sub

JackDanIce that works thanks a lot!

 

[JackDanIce]

You're welcome