VBA: If…Then…Else Statements Issue

[zero269]

Hello,

I'm having some trouble getting an If…Then…Else Statement to work using multiple ElseIf conditions.
Currently, it will only take action on the first condition and none of the others.

VBA Testing.xlsm
	A
1	Digital Library
2	hoopladigital
3	openlibrary
4	lacountylibrary
5	GlendaleLAC
If-Then-Else

I commented out the Else portion as according to M$, it's optional: If...Then...Else statement (VBA)

Public Sub dLibrary2()

    'Digital Library Column
    Dim Scheme As String, Domain As String, CloudDomain As String
    Scheme = "https://"
    Domain = ActiveCell.Value
    CloudDomain = "https://ebook.yourcloudlibrary.com/library/"
    
    'Validate Selection
    If Len(Domain) > 0 Then
        If Domain = "hoopladigital" Then ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".com", , , Domain
        ElseIf Domain = "openlibrary" Then ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".org", , , Domain
        ElseIf Domain = LCase(Domain) Then ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".overdrive.com", , , Domain
        ElseIf Len(Domain) > 0 Then ActiveCell.Hyperlinks.Add ActiveCell, CloudDomain & Domain, , , Domain
        'Else

    End If

End Sub

Any help would be greatly appreciated...

 

[rlv01]

Recommend you restructure to make your code easier to follow and debug.

Public Sub dLibrary2()
   
    'Digital Library Column
    Dim Scheme As String, Domain As String, CloudDomain As String
    Scheme = "https://"
    Domain = ActiveCell.Value
    CloudDomain = "https://ebook.yourcloudlibrary.com/library/"
   
    'Validate Selection
    If Len(Domain) > 0 Then
        If Domain = "hoopladigital" Then
            ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".com", , , Domain
            Debug.Print "Condition 1"
        ElseIf Domain = "openlibrary" Then
            ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".org", , , Domain
            Debug.Print "Condition 2"
        ElseIf Domain = LCase(Domain) Then
            ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".overdrive.com", , , Domain
            Debug.Print "Condition 3"
        ElseIf Len(Domain) > 0 Then
            ActiveCell.Hyperlinks.Add ActiveCell, CloudDomain & Domain, , , Domain
            Debug.Print "Condition 4"
        Else
            Debug.Print "None of the conditions have been met"
        End If
    End If
End Sub

 

[zero269]

Recommend you restructure to make your code easier to follow and debug.

Public Sub dLibrary2()
  
    'Digital Library Column
    Dim Scheme As String, Domain As String, CloudDomain As String
    Scheme = "https://"
    Domain = ActiveCell.Value
    CloudDomain = "https://ebook.yourcloudlibrary.com/library/"
  
    'Validate Selection
    If Len(Domain) > 0 Then
        If Domain = "hoopladigital" Then
            ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".com", , , Domain
            Debug.Print "Condition 1"
        ElseIf Domain = "openlibrary" Then
            ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".org", , , Domain
            Debug.Print "Condition 2"
        ElseIf Domain = LCase(Domain) Then
            ActiveCell.Hyperlinks.Add ActiveCell, Scheme & Domain & ".overdrive.com", , , Domain
            Debug.Print "Condition 3"
        ElseIf Len(Domain) > 0 Then
            ActiveCell.Hyperlinks.Add ActiveCell, CloudDomain & Domain, , , Domain
            Debug.Print "Condition 4"
        Else
            Debug.Print "None of the conditions have been met"
        End If
    End If
End Sub

Thanks for taking the time to help me with this.
I realize now I failed to close out my 2nd IF statement.
However, I like the debugging you applied and will use your updated code as is.

VBA Testing.xlsm
	A
1	Digital Library
2	hoopladigital
3	openlibrary
4	lacountylibrary
5	GlendaleLAC
If-Then-Else

Thanks a lot and best regards...