VBA - GetOpenFilename

[Dao Ha Quang]

Sub CopySheetFromClosedWB()
Application.ScreenUpdating = False
Filename = Application.GetOpenFilename("Excel Files (*.xls;*.xlsx;*.xlsm),*.xls;*.xlsx;*.xlsm")
Set closedBook = Workbooks.Open(Filename)

closedBook.Sheets("Sheet1").Move Before:=ThisWorkbook.Sheets("TT")

closedBook.Close SaveChanges:=False
Application.ScreenUpdating = True

Call Macro2

End Sub

I use this code to copy 1 sheet from 1 closed file and then run "MACRO 2"
When I run it, it OPEN the file and I select the file, marco still runs normally,
but when I don't select file and CANCEL, my "MACRO 2" is still running and it crashes
I want "MACRO 2" to run only after I have selected OPEN a file
Thank you.

 

[DanteAmor]

Hi @Dao Ha Quang.

Welcome to the MrExcel forum. Please accept my warmest greetings and sincere hope that all is well.​

Add the line highlighted in blue:

Sub CopySheetFromClosedWB()
  Dim Filename As Variant
  Dim closedBook As Workbook
 
  Application.ScreenUpdating = False
  Filename = Application.GetOpenFilename("Excel Files (*.xls;*.xlsx;*.xlsm),*.xls;*.xlsx;*.xlsm")
 
  If Filename = False Then Exit Sub
 
  Set closedBook = Workbooks.Open(Filename)
 
  closedBook.Sheets("Sheet1").Move Before:=ThisWorkbook.Sheets("TT")
 
  closedBook.Close SaveChanges:=False
  Application.ScreenUpdating = True
 
  Call Macro2

End Sub

--------------
Let me know the result and I'll get back to you as soon as I can.
Sincerely
Dante Amor
--------------

 

[Dao Ha Quang]

Xin chào @Dao Hà Quang.

Chào mừng bạn đến với diễn đàn MrExcel. Xin hãy chấp nhận lời chào nồng nhiệt nhất của tôi và hy vọng chân thành rằng tất cả đều tốt đẹp.​

Thank so much