VBA form OK_click not returning to calling Sub

[myall_blues]

Hi

I have an issue with a Sub that calls a userform - after I click OK on the form it does not continue with the Sub but rather just stops. Debugging seems to indicate that is stays at the 'show' statement in the sub. I have this same code in another application and it works perfectly, and I have been unable to figure out the difference.
Here is my Sub calling code:

Private Sub ImportData()
    '
    '
    ' Get input filename from form
    '
    Dim frm As New frmGetFile
    With frm
        .Show                                         ' <= Never goes past this line
        If Not .TypeCancelled Then
            '
            ' Do some further processing
            '
        End If
        '
        ' Clean up
        '
        Unload frm
        Set frm = Nothing
    End With
End Sub

And here is the code in my userform:

Option Explicit
Private cancelled As Boolean
Public Property Get TypeCancelled() As Boolean
    TypeCancelled = cancelled
End Property
Private Sub cmdGetFileCancel_Click()
    '
    ' Cancel button - unload form
    '
    OnCancel
End Sub
Private Sub OnCancel()
    Hide
    cancelled = True
End Sub
Private Sub UserForm_QueryClose(Cancel As Integer, CloseMode As Integer)
    If CloseMode = VbQueryClose.vbFormControlMenu Then
        Cancel = True
        OnCancel
    End If
End Sub
Private Sub cmdGetFileOK_Click()
    '
    Dim r As Integer
    Dim wksNewSheet As Excel.Worksheet
    Dim TempVal As String, ErrorString As String
    '
    ' Check that all mandatory values have been completed
    '
    With Me
        If Len(Label5.Caption) = 0 Or Len(ComboBox1.Value) = 0 Then
            ErrorString = ErrorString + "Please complete all mandatory fields (marked by *)." & vbNewLine
            MsgBox ErrorString, vbCritical, "Values Missing"
            OnCancel
            Exit Sub
'        Else
'            cancelled = False
        End If
    End With
    If Not cancelled Then
        '
        ' Do some stuff
        '
    End If
End Sub

Any thoughts gratefully appreciated. I've been looking at this for hours.

 

[RoryA]

Have you set a breakpoint in the cmdGetFileOK_Click routine and stepped through to see what is happening? If so, which lines get executed?

 

[nemmi69]

This is how I do the close even so you could adapt it for yours

Private Sub CButton_Close_Click()
    If EditForm.CButton_Save.Enabled = True Then
        If MsgBox("This will lose any unsaved data. Are you sure?", vbYesNo) = vbNo Then Exit Sub
    End If
    Reset_Form
' Hide but do not unload form
    EditForm.Hide

End Sub

 

[myall_blues]

Have you set a breakpoint in the cmdGetFileOK_Click routine and stepped through to see what is happening? If so, which lines get executed?

It steps all the way to the End Sub and stops. In the VBA window the run button is greyed out and in the workbook the form is still displayed.
If I click 'Break' at that point the next line to execute is .Show.

 

[RoryA]

If it doesn't process that If block, there is no code to hide the form.

 

[myall_blues]

If it doesn't process that If block, there is no code to hide the form.

Can you clarify which If block you mean please? I'm not clear how to fix the issue.

 

[myall_blues]

If it doesn't process that If block, there is no code to hide the form.

Can you clarify which If block you mean please? I'm not clear how to fix the issue.

Never mind - I figured it out. Thank you very much for your assistance Rory - it had me stumped.
Regards
Murray

 

[RoryA]

Glad you solved it.