VBA - Extract data by matching value - error

[JetSetDrive]

Can anyone assist me with figuring out why excel is not pulling over the rows that match the search criteria? The message box is showing no values found even though there are matching values. Is it because the value is set to "0"?

Dim lastrow As Long
Dim c As Long
Dim s As Variant
Dim ans As String
ans = ActiveSheet.Name
Sheets.Add(After:=Sheets(Sheets.Count)).Name = "No MinMax"
c = 12
s = "0"
lastrow = Sheets(ans).Cells(Rows.Count, c).End(xlUp).Row
With Sheets(ans).Cells(1, c).Resize(lastrow)
.AutoFilter 1, s
counter = .Columns(c).SpecialCells(xlCellTypeVisible).Count
If counter > 1 Then
.Offset(1).Resize(.Rows.Count - 1).SpecialCells(xlCellTypeVisible).EntireRow.Copy Sheets("No MinMax").Rows(2)
Sheets(ans).Rows(1).Copy Sheets("No MinMax").Rows(1)
Else
MsgBox "No values found"
End If
.AutoFilter
End With
application.ScreenUpdating = True
End Sub

 

[sykes]

You've set ans to the old activesheet, so it's looking in whatever the activesheet was BEFORE you added the new sheet.
Try:

Dim lastrow As Long
Dim c As Long
Dim s As Variant
Dim ans As String

Sheets.Add(After:=Sheets(Sheets.Count)).Name = "No MinMax"
ans = ActiveSheet.Name
c = 12
s = "0"
lastrow = Sheets(ans).Cells(Rows.Count, c).End(xlUp).Row
With Sheets(ans).Cells(1, c).Resize(lastrow)
.AutoFilter 1, s
counter = .Columns(c).SpecialCells(xlCellTypeVisible).Count
If counter > 1 Then
.Offset(1).Resize(.Rows.Count - 1).SpecialCells(xlCellTypeVisible).EntireRow.Copy Sheets("No MinMax").Rows(2)
Sheets(ans).Rows(1).Copy Sheets("No MinMax").Rows(1)
Else
MsgBox "No values found"
End If
.AutoFilter
End With
Application.ScreenUpdating = True
End Sub

 

[Fluff]

@sykes
Your code is looking at the newly created sheet, which will be totally blank.

 

[sykes]

Disregard previous post - looks like you DID want to search the previously active sheet...

 

[Fluff]

@JetSetDrive
You're code works for me, although you could simplify the copy/paste like

If counter > 1 Then
   .SpecialCells(xlCellTypeVisible).EntireRow.Copy Sheets("No MinMax").Range("A1")
Else
   MsgBox "No values found"
End If

Make sure that you actually have values that are 0 rather than 0.0000001.
Also the cell format needs to show as 0 rather than 0.00

 

[JetSetDrive]

Correct, the data is being pulled over from the first active worksheet.

 

[sykes]

Works for me, too (with a couple of "0"s in the previously activesheet, Column L).
Could it be that you wanted to count cells <> 0, rather than =0?

 

[JetSetDrive]

Thank you everyone, it turns out the previous macro did not remove the filters. I corrected this and it resolved the error

 

[sykes]

Good find!
Thanks for closing out your post.