VBA error handling problem

[robw]

Hi,
I’m having a problem with the following tract of VBA. It is intended that it should loop round until a window with a particular title (as held in string wtit) is detected. It works ok if the said window already exists before running the code, but it fails on the SECOND time round the loop if the window does not pre-exist.

I assume I’m doing something wrong in the error handling or error clearing but I cannot figure it out. Any suggestions on what I’m doing wrong, please?

Many Thanks
Rob

    For appacttry = 1 To 3
        On Error GoTo appactfail
            AppActivate wtit  ‘fails HERE on the second time round the loop  
                                              ‘with message “Run-time error 5 – Invalid procedure call or argument
        On Error GoTo 0
        GoTo appactok
appactfail:
        Err.clear  
        On Error GoTo 0
        MsgBox "failed to find window on try number  " & appacttry  
  Next appacttry
appactok:

 

[Fluff]

To learn about error handling, have a look here http://excelmatters.com/2015/03/17/on-error-wtf/

 

[robw]

To learn about error handling, have a look here http://excelmatters.com/2015/03/17/on-error-wtf/

Thanks Fluff.... The link you provided makes a lot of sense; better than the Microsoft documentation. I tried the "dirty solution" using On Error GoTo -1 and it worked. I will however also do the honourable thing and restructure my code to adopt the "clean solution". Thanks again!
Cheers
Rob

 

[Fluff]

You're welcome & thanks for the feedback

 

[RoryA]

The link you provided makes a lot of sense

That's nice to hear - I rarely make sense.