VBA Dimed Value Called in a Sub

[Table83]

This is a little hard to explain so bear with me.
I'm trying to dim a value, call a sub and use that dimmed value within the sub.

Sub InitialSub()
Dim Value1, Value2, Value3 As Double
Value1 = Worksheets("Sheet1").Range("A1")
Value1 = Worksheets("Sheet1").Range("A2")
Sub2
Worksheets("Sheet1").Range("A3") = Value3
End Sub
 
Sub Sub2()
Value3 = Value1 + Value2
End Sub

I'm still pretty new at VBA so any help would be appreciated. I'm creating a program for my investment society. I wrote the code all out in a new way. When I tried it and it totally flopped because of this reason. So close and yet so far!

 

[sous2817]

Hello and welcome to the board!

A couple of things,

1) you can dim the variables at the top of the module (above any 'Sub') to make the public. This allows you to use them within other subs in the same module.

2) Your variables are miss dimmed a bit. The first two are dimmed as variants and only the last is dimmed as a double (unless that was your intent).

Nonetheless, this seemed to work for me in my test sheet:

Option Explicit
Dim Value1 As Double, Value2 As Double, Value3 As Double
Sub InitialSub()

Value1 = Worksheets("Sheet1").Range("A1")
Value2 = Worksheets("Sheet1").Range("A2")
Call Sub2
Worksheets("Sheet1").Range("A3") = Value3
End Sub
 
Sub Sub2()
Value3 = Value1 + Value2
End Sub

 

[djreiswig]

Could use a function instead of a sub, and then just pass the values to the function.

 Sub InitialSub()
    Dim Value1 As Double, Value2 As Double, Value3 As Double
    Value1 = Worksheets("Sheet1").Range("A1")
    Value2 = Worksheets("Sheet1").Range("A2")
    Worksheets("Sheet1").Range("A3") = Sub2(Value1, Value2)
End Sub
 
Function Sub2(Value1 As Double, Value2 As Double) As Double
    Sub2 = Value1 + Value2
End Function

Or do away with the variables all together

Sub InitialSub()
    With Worksheets("Sheet1")
        .Range("A3") = Sub2(.Range("A1"), .Range("A2"))
    End With
End Sub
 
Function Sub2(Value1 As Double, Value2 As Double) As Double
    Sub2 = Value1 + Value2
End Function