VBA Cut/paste based on cell value

jashotze

New Member
Joined
Apr 2, 2018
Messages
6
Hey All,
First time poster, as I am having a real crap time getting this code to work... I found a segment on one of these forums and need to amend it slightly... I need to detail the row that is copied and subsequently pasted.

I have tried every form of syntax I know how. Even paid 20 bucks an hour for an online Code Mentor and they could get it to work. I don't know if it needs to be just scrapped and started over or what. I have tried probably 30 different variations to accomplish this, even recorded the entire thing of searching, cutting and deleting. No Luck.

From the marginal amount I know this one seems to have some extra stuff (A1.Select) but when I remove it the I get object errors. But if the line to delete can be found I won't care haha.

This code works, it just doesn't delete.... Please help!!!!

Code:
[COLOR=#000000][FONT=Helvetica]Sub Completed_Rows()[/FONT][/COLOR]

[COLOR=#000000][FONT=Helvetica]'Unprotect a worksheet with a password[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]Sheets("Hi-Pri").Unprotect Password:="ov22gov"[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]Sheets("Completed").Unprotect Password:="ov22gov"[/FONT][/COLOR]

[COLOR=#000000][FONT=Helvetica]Dim lr As Long, lr2 As Long, r As Long[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]lr = Sheets("Hi-Pri").Cells(Rows.Count, "A").End(xlUp).Row[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]lr2 = Sheets("Completed").Cells(Rows.Count, "A").End(xlUp).Row[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]For r = lr To 2 Step -1[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]   If Range("T" & r).Value = "Complete" Then[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]       Rows(r).Copy Destination:=Sheets("Completed").Range("A" & lr2 + 1)[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]       lr2 = Sheets("Completed").Cells(Rows.Count, "A").End(xlUp).Row[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]   End If[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]   Range("A1").Select[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]Next r[/FONT][/COLOR]

[COLOR=#000000][FONT=Helvetica]'Protect worksheet with a password[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]Sheets("Hi-Pri").Protect Password:="ov22gov"[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]'ActiveWorkbook.Save[/FONT][/COLOR]
[COLOR=#000000][FONT=Helvetica]Sheets("Completed").Protect Password:="ov22gov"[/FONT][/COLOR]
 
Last edited by a moderator:

Excel Facts

Whats the difference between CONCAT and CONCATENATE?
The newer CONCAT function can reference a range of cells. =CONCATENATE(A1,A2,A3,A4,A5) becomes =CONCAT(A1:A5)
Hi & welcome to the board.
The reason it's not deleting anything, is because you haven't told it to ;)
Try
Code:
Rows(r).Copy Destination:=Sheets("Completed").Range("A" & lr2 + 1)
Rows(r).Delete
lr2 = Sheets("Completed").Cells(Rows.Count, "A").End(xlUp).Row
 
Upvote 0
In that case I can't think why you'd get that particular error.
Can you delete one of those rows manually?
 
Upvote 0
I just tested it and if I select the row and delete it works fine. No issues..

Would a private sub I have running on the worksheet have anything to do with it? Its a timestamp in a column based on data in a different cell and works flawlessly. I do notice that data entry into any cell causes excel to think for just a second as I presume its running the script to see if the private subs parameters are met. The manual deletion worked fine even with the private sub working.
 
Upvote 0
If it's an Event code try
Code:
Sub Completed_Rows()

'Unprotect a worksheet with a password
   Sheets("Hi-Pri").Unprotect Password:="ov22gov"
   Sheets("Completed").Unprotect Password:="ov22gov"
   
   Dim lr As Long, lr2 As Long, r As Long
   lr = Sheets("Hi-Pri").Cells(Rows.Count, "A").End(xlUp).Row
   lr2 = Sheets("Completed").Cells(Rows.Count, "A").End(xlUp).Row
Application.EnableEvents = False
   For r = lr To 2 Step -1
      If Range("T" & r).Value = "Complete" Then
          Rows(r).Copy Destination:=Sheets("Completed").Range("A" & lr2 + 1)
          Rows(r).Delete
          lr2 = Sheets("Completed").Cells(Rows.Count, "A").End(xlUp).Row
      End If
   Next r
   Range("A1").Select
Application.EnableEvents = True
   
   'Protect worksheet with a password
   Sheets("Hi-Pri").Protect Password:="ov22gov"
   'ActiveWorkbook.Save
   Sheets("Completed").Protect Password:="ov22gov"
End Sub
 
Upvote 0

Forum statistics

Threads
1,223,230
Messages
6,170,883
Members
452,364
Latest member
springate

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top