VBA Copy and Paste from Open File Dialog - Runtime Error 1004 Application-Defined or object-defined error

CyricPL

New Member
Joined
Sep 12, 2017
Messages
4
I've got a macro to select a file from the Open File dialog, copy the data, and paste it into a worksheet in another workbook. However, I get a runtime error 1004 at the paste step. Anyone know how to fix it?

Code:
Public Sub GetRange()
     
Dim ReportWbk As Workbook 'workbook with report data
Dim Report As String 'name of file with report data
Application.FileDialog(msoFileDialogFilePicker).Show
Report = Application.FileDialog(msoFileDialogFilePicker).SelectedItems(1)
Set ReportWbk = Workbooks.Open(Report)
ReportWbk.Sheets(1).Cells.Copy
Application.DisplayAlerts = False
ReportWbk.Close (False)
ThisWorkbook.Sheets("Selector to Validate").Activate
Cells(1, 1).Select: ActiveSheet.Paste
     
End Sub
 

Excel Facts

Lock one reference in a formula
Need 1 part of a formula to always point to the same range? use $ signs: $V$2:$Z$99 will always point to V2:Z99, even after copying
Maybe because you've closed the workbook that contains the copied cells. Try this instead:

Code:
Public Sub GetRange()
     
Dim ReportWbk As Workbook 'workbook with report data
Dim Report As String 'name of file with report data
Dim TargetWbk As Workbook 'this workbook

Set TargetWbk = ThisWorkbook
Application.FileDialog(msoFileDialogFilePicker).Show
Report = Application.FileDialog(msoFileDialogFilePicker).SelectedItems(1)
Set ReportWbk = Workbooks.Open(Report)
ReportWbk.Sheets(1).Cells.Copy Destination:=TargetWbk.Sheets("Selector to Validate").Cells(1, 1)
Application.DisplayAlerts = False
ReportWbk.Close False
ThisWorkbook.Sheets("Selector to Validate").Activate
     
End Sub

WBD
 
Upvote 0
Deleted
WBD's is a better way
 
Last edited:
Upvote 0

Forum statistics

Threads
1,224,823
Messages
6,181,181
Members
453,022
Latest member
Mohamed Magdi Tawfiq Emam

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top