VBA compile error else without if

[helium]

Hi guys,

I'm new at writing vba and am trying to get this user form working but keep getting the compile error: Else without if.

Private Sub cmdOK_Click()
    ActiveWorkbook.Sheets("Course Bookings").ActivateRange("A1").Select
    Do
    If IsEmpty(ActiveCell) = False Then
        ActiveCell.Offset(1, 0).Select
    End If
    Loop Until IsEmpty(ActiveCell) = True
    ActiveCell.Value = txtName.Value
    ActiveCell.Offset(0, 1) = txtPhone.Value
    ActiveCell.Offset(0, 2) = cboDepartment.Value
    ActiveCell.Offset(0, 3) = cboCourse.Value
    If optIntroduction = True Then ActiveCell.Offset(0, 4).Value = "Intro"
    [B]ElseIf optIntermediate = True Then[/B]
            ActiveCell.Offset(0, 4).Value = "Intermd"
                Else
                ActiveCell.Offset(0, 4).Value = "Adv"
                End If
                If chkLunch = True Then
                    ActiveCell.Offset(0, 5).Value = "Yes"
                Else
                    ActiveCell.Offset(0, 5).Value = "No"
                End If
                If chkVegetarian = True Then
                ActiveCell.Offset(0, 6).Value = "Yes"
                Else
                    If chkLunch = False Then
                    ActiveCell.Offset(0, 6).Value = ""
                    Else
                    ActiveCell.Offset(0, 6).Value = "No"
                End If
                Range("A1").Select

The bolded text is what the editor highlights. What am I going wrong?

 

[Norie]

This a complete If statement.

If optIntroduction = True Then ActiveCell.Offset(0, 4).Value = "Intro"

Anything after it isn't part of the If statement.

Try this.

If optIntroduction = True Then 
       ActiveCell.Offset(0, 4).Value = "Intro"
ElseIf  optIntermediate = True Then
       ActiveCell.Offset(0, 4).Value = "Intermd"
Else
       ActiveCell.Offset(0, 4).Value = "Adv"
End If

 

[helium]

Thanks Norie!

However, now I'm getting a different error: Block If without End If. The new code I'm trying is...

Private Sub cmdOK_Click()
    ActiveWorkbook.Sheets("Course Bookings").ActivateRange("A1").Select
Do
If IsEmpty(ActiveCell) = False Then
    ActiveCell.Offset(1, 0).Select
End If
Loop Until IsEmpty(ActiveCell) = True
    ActiveCell.Value = txtName.Value
    ActiveCell.Offset(0, 1) = txtPhone.Value
    ActiveCell.Offset(0, 2) = cboDepartment.Value
    ActiveCell.Offset(0, 3) = cboCourse.Value
If optIntroduction = True Then
       ActiveCell.Offset(0, 4).Value = "Intro"
ElseIf optIntermediate = True Then
       ActiveCell.Offset(0, 4).Value = "Intermd"
Else
       ActiveCell.Offset(0, 4).Value = "Adv"
End If
    If chkLunch = True Then
        ActiveCell.Offset(0, 5).Value = "Yes"
    Else
        ActiveCell.Offset(0, 5).Value = "No"
    End If
    If chkVegetarian = True Then
        ActiveCell.Offset(0, 6).Value = "Yes"
    Else
    If chkLunch = False Then
        ActiveCell.Offset(0, 6).Value = ""
    Else
        ActiveCell.Offset(0, 6).Value = "No"
    End If
        Range("A1").Select
[B]End Sub[/B]

It now highlights "End Sub."

Sorry completely new at vba trying to debug code I got from someone.

 

[Jonmo1]

Proper indentation of code will help discover these issues.
You were missing the Red End If

Private Sub cmdOK_Click()
ActiveWorkbook.Sheets("Course Bookings").ActivateRange("A1").Select
Do
    If IsEmpty(ActiveCell) = False Then
        ActiveCell.Offset(1, 0).Select
    End If
Loop Until IsEmpty(ActiveCell) = True
 
ActiveCell.Value = txtName.Value
ActiveCell.Offset(0, 1) = txtPhone.Value
ActiveCell.Offset(0, 2) = cboDepartment.Value
ActiveCell.Offset(0, 3) = cboCourse.Value
 
If optIntroduction = True Then
    ActiveCell.Offset(0, 4).Value = "Intro"
ElseIf optIntermediate = True Then
    ActiveCell.Offset(0, 4).Value = "Intermd"
Else
    ActiveCell.Offset(0, 4).Value = "Adv"
End If
 
If chkLunch = True Then
    ActiveCell.Offset(0, 5).Value = "Yes"
Else
    ActiveCell.Offset(0, 5).Value = "No"
End If
 
If chkVegetarian = True Then
    ActiveCell.Offset(0, 6).Value = "Yes"
Else
    If chkLunch = False Then
        ActiveCell.Offset(0, 6).Value = ""
    Else
        ActiveCell.Offset(0, 6).Value = "No"
    End If
End If
Range("A1").Select
End Sub

 

[helium]

Thanks Jonmo1,

No longer coming up with that error.. But now it is coming with 'Runtime erorr 9 subscript out of range'

 

[Norie]

Where is that error happening?

 

[helium]

Don't worry, fixed it!

I changed

ActiveWorkbook.Sheets("Course Bookings").ActivateRange("A1").Select

to..

    Application.Goto (ActiveWorkbook.Sheets("Course Bookings").Range("A1"))

The whole code is now..

Private Sub cmdOK_Click()
    'ActiveWorkbook.Sheets("Course Bookings").ActivateRange("A1").Select
    Application.Goto (ActiveWorkbook.Sheets("Course Bookings").Range("A1"))
Do
If IsEmpty(ActiveCell) = False Then
    ActiveCell.Offset(1, 0).Select
End If
Loop Until IsEmpty(ActiveCell) = True
    ActiveCell.Value = txtName.Value
    ActiveCell.Offset(0, 1) = txtPhone.Value
    ActiveCell.Offset(0, 2) = cboDepartment.Value
    ActiveCell.Offset(0, 3) = cboCourse.Value
If optIntroduction = True Then
       ActiveCell.Offset(0, 4).Value = "Intro"
ElseIf optIntermediate = True Then
       ActiveCell.Offset(0, 4).Value = "Intermd"
Else
       ActiveCell.Offset(0, 4).Value = "Adv"
End If
    If chkLunch = True Then
        ActiveCell.Offset(0, 5).Value = "Yes"
    Else
        ActiveCell.Offset(0, 5).Value = "No"
    End If
    If chkVegetarian = True Then
        ActiveCell.Offset(0, 6).Value = "Yes"
    Else
    If chkLunch = False Then
        ActiveCell.Offset(0, 6).Value = ""
    Else
        ActiveCell.Offset(0, 6).Value = "No"
    End If
        Range("A1").Select
    End If
End Sub

Cheers for your help