VBA Code Corrupting files suddenly

[rachelm920]

Hi all,
I have a code that opens all Excel files in the designated folder, then performs actions based on the file name. I've been using this method for a long time, but suddenly recently its been corrupting files. Then the whole thing just sits there with an error message because it can't open the file. The file corruption happens randomly and on different file names each time, so it's not them. Some of the code has adding tables and formatting, but it hiccups on any of them, and usually the more simple ones.

Sample code:
Main Code:

Sub AllFiles()
Dim folderpath, filename as string
Dim wb as workbook
folderpath = "C:\Samplefolder\Reports\"
filename = Dir(folderpath & "*.xlsx")
Do while filename <> ""
 Set wb = Workbooks.Open(folderPath & filename)
         Application.DisplayAlerts = False
        'Call a subroutine here to operate on the just-opened workbook
        Reports
            
        filename = Dir
    Loop
  Application.ScreenUpdating = False
  Application.Wait (Now + TimeValue("0:00:30"))
End Sub

Report code: (there's a lot more than 2 lol)

Sub Reports()
'The report names'
Dim Report1, Report2 as Integer
Dim MyFile As string
'Turn off the alerts'
Application.DisplayAlerts = False

'Define the reports'
Report1 = Instr(MyFile, "Report1")
Report2 = Instr(Myfile, "Report2")

'Coding for the reports'
    If Report1 = 1 then
    Call MyReport1
    ElseIf Report2 = 1 then
    Call MyReport2
End If
End Sub

Sample of printed report

Sub MyReport1()
Dim MyName, MyWorkbook, MyFolder As String
    MyName = ActiveWorkbook.FullName
    MyWorkbook = MyName
    MyFolder = "C:\SampleFolder\Reports\MyReport1\"
        Call PrintOffice
            ActiveWorkbook.SaveAs MyFolder & ActiveWorkbook.Name
                Kill MyWorkbook
                ActiveWorkbook.Close
                    
    MyName = ""
    MyWorkbook = ""
    MyFolder = ""

        
End Sub

Sample of Saved Report

Sub MyReport2()
Dim MyName, MyWorkbook, MyFolder As String
    MyName = ActiveWorkbook.FullName
    MyWorkbook = MyName
    MyFolder = "C:\SampleFolder\Reports\MyReport2\"
        ActiveWorkbook.SaveAs MyFolder & ActiveWorkbook.Name
            Kill MyWorkbook
            ActiveWorkbook.Close
            
    MyName = ""
    MyWorkbook = ""
    MyFolder = ""
    
End Sub

The printer code

Sub PrintOffice()
Application.ActivePrinter = "\\domainname\printername on Ne04:"
    

ActiveWindow.SelectedSheets.PrintOut copies:=1, collate:=True, ignoreprintareas:=False
End Sub

 

[RoryA]

Your SaveAs is not specifying a file format. You should always include that.

 

[rachelm920]

OK I changed it from

ActiveWorkbook.SaveAs MyFolder & ActiveWorkbook.Name

To

ActiveWorkbook.SaveAs MyFolder & ActiveWorkbook.Name &".xlsx"

but now it's adding .xlsx to the file name. Is there something else I'm missing?

 

[Georgiboy]

More like this:

ActiveWorkbook.SaveAs MyFolder & ActiveWorkbook.Name, 51

File formats:
XlFileFormat enumeration (Excel)

 

[RoryA]

Given that they are existing workbooks, I'd just use whatever file format they are already:

ActiveWorkbook.SaveAs MyFolder & ActiveWorkbook.Name, activeworkbook.fileformat