VBA Calling Subs - Efficient?

[Nysius]

Hi Everyone,

Not sure if this can be answered easily but here it goes:

I've created a module in VBA where I've placed a sub macro containing:

Sub BG_UpdatingOFF()
Application.ScreenUpdating = False
Application.Calculation = xlCalculationManual
End Sub


Sub BG_UpdatingON()
Application.Calculation = xlCalculationAutomatic
Application.ScreenUpdating = True
End Sub

I then 'Call' these macros in my form scripts etc. My question: Is it more efficient to just write these lines in the particular form/module code or am I still being efficient by calling the functions? What is the preferred "best practice" way of doing this?

Thanks for the help!

 

[JoeMo]

Seems an unusual way to do what those subroutines do, but calling subroutines is not necessarily inefficient. Unless you notice some degradation in speed of execution using these subs, why be concerned about it?

 

[jtakw]

Hi,

I don't know if there is any significant performance difference between either way; however, if you have a lot of "Subs" or codes that require UpdatingOn and UpdatingOff, it just makes it easier to Call these in your Subs than to type them over and over again.