VBA ADODB query Excel workbook as source, how to join?

Jaymond Flurrie

Well-known Member
Joined
Sep 22, 2008
Messages
921
Office Version
  1. 365
Platform
  1. Windows
I'm trying to query one Excel Workbook, two separate places to join them.

Here's the source book, the name of the worksheet is Sheet:
1682953995797.png

And here's the code. Note that I have a simpler query there that doesn't give me any errors, just to prove the problem is somehow with the join. The one with join gives run-time error -2147217900 (80040e14) with message "Syntax error in FROM clause".

VBA Code:
Sub JoinTest()
    'Here's the SQL I'm trying to perform
    'SELECT o.OneValue
    'FROM One o
    'JOIN Two t
    'ON o.OneID = t.TwoID
    
    Dim connection As Object
         
    Set connection = CreateObject("ADODB.Connection")
    With connection
        .Provider = "Microsoft.ACE.OLEDB.12.0"
        .ConnectionString = "Data Source=" & ThisWorkbook.FullName & ";" & _
        "Extended Properties=""Excel 12.0 Xml;HDR=Yes"";"
        .Open
    End With
    
    
    Dim workingsql As String
    workingsql = "SELECT o.OneValue " & _
    " FROM [Sheet$A1:B4] o "
    
    Dim workingresult As Object
    Set workingresult = connection.Execute(workingsql)
    
    Dim nonworkingsql As String
    nonworkingsql = "SELECT o.OneValue " & _
    " FROM [Sheet$A1:B4] o " & _
    " JOIN [Sheet$E1:G5] t " & _
    " ON o.OneID = t.TwoID"
    
    Dim nonworkingresult As Object
    Set nonworkingresult = connection.Execute(nonworkingsql)
    
    'And then whatever handling logic here, I just want that join to work to begin with
End Sub

My Excel version is actually 16.0, but that 12.0 seems to work better (well, excluding this join) for some reason. Using 16.0 in connection properties gives "Could not find installable ISAM", but let's not concentrate on this version part unless it is really mandatory for the join to work. I just want the join to work, the rest doesn't really matter right now.
 

Excel Facts

Does the VLOOKUP table have to be sorted?
No! when you are using an exact match, the VLOOKUP table can be in any order. Best-selling items at the top is actually the best.
I'm trying to query one Excel Workbook, two separate places to join them.

Here's the source book, the name of the worksheet is Sheet:
View attachment 90703
And here's the code. Note that I have a simpler query there that doesn't give me any errors, just to prove the problem is somehow with the join. The one with join gives run-time error -2147217900 (80040e14) with message "Syntax error in FROM clause".

VBA Code:
Sub JoinTest()
    'Here's the SQL I'm trying to perform
    'SELECT o.OneValue
    'FROM One o
    'JOIN Two t
    'ON o.OneID = t.TwoID
   
    Dim connection As Object
        
    Set connection = CreateObject("ADODB.Connection")
    With connection
        .Provider = "Microsoft.ACE.OLEDB.12.0"
        .ConnectionString = "Data Source=" & ThisWorkbook.FullName & ";" & _
        "Extended Properties=""Excel 12.0 Xml;HDR=Yes"";"
        .Open
    End With
   
   
    Dim workingsql As String
    workingsql = "SELECT o.OneValue " & _
    " FROM [Sheet$A1:B4] o "
   
    Dim workingresult As Object
    Set workingresult = connection.Execute(workingsql)
   
    Dim nonworkingsql As String
    nonworkingsql = "SELECT o.OneValue " & _
    " FROM [Sheet$A1:B4] o " & _
    " JOIN [Sheet$E1:G5] t " & _
    " ON o.OneID = t.TwoID"
   
    Dim nonworkingresult As Object
    Set nonworkingresult = connection.Execute(nonworkingsql)
   
    'And then whatever handling logic here, I just want that join to work to begin with
End Sub

My Excel version is actually 16.0, but that 12.0 seems to work better (well, excluding this join) for some reason. Using 16.0 in connection properties gives "Could not find installable ISAM", but let's not concentrate on this version part unless it is really mandatory for the join to work. I just want the join to work, the rest doesn't really matter right now.
You may try this Access SQL query and see if it works.
SQL:
SELECT [Sheet1$A1:B4].[OneId]
FROM [Sheet1$A1:B4] INNER JOIN [Sheet1$E1:G5] ON [Sheet1$A1:B4].[OneId] =  [Sheet1$E1:G5].[TwoId];
1682956057060.png
 
Upvote 1
This seems to work:
VBA Code:
Sub JoinTest()
    'Here's the SQL I'm trying to perform
    'SELECT o.OneValue
    'FROM One o
    'JOIN Two t
    'ON o.OneID = t.TwoID
    
    Dim conn As New ADODB.connection
    conn.Open "Provider=Microsoft.ACE.OLEDB.12.0;Data Source=" & ThisWorkbook.FullName & _
    ";Extended Properties=""Excel 12.0;HDR=YES;"";"
    
    Dim query As String
    query = "SELECT o.[OneValue]" & _
    " FROM [One$A1:B4] AS o" & _
    " INNER JOIN [One$D1:F5] AS t" & _
    " ON o.[OneID] = t.[TwoID]"
    
    
    Dim rs As New ADODB.Recordset
    rs.Open query, conn
    
    conn.Close
End Sub

It is slightly different solution, but close to the original.
 
Upvote 0
One critical issue I had wrong is that ADODB doesn't understand JOIN. It does understands INNER JOIN.
So this doesn't work:
VBA Code:
"SELECT o.OneValue " & _
    " FROM [Sheet$A1:B4] o " & _
    " JOIN [Sheet$E1:G5] t " & _
    " ON o.OneID = t.TwoID"

But this does:
VBA Code:
"SELECT o.OneValue " & _
    " FROM [Sheet$A1:B4] o " & _
    " INNER JOIN [Sheet$E1:G5] t " & _
    " ON o.OneID = t.TwoID"
 
Upvote 0

Forum statistics

Threads
1,224,823
Messages
6,181,181
Members
453,022
Latest member
Mohamed Magdi Tawfiq Emam

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top