Using time with Select Case

[Pookiemeister]

What am I doing wrong? The time now is 3:24 AM and when I run this code, the greeting should be equal to "Good morning" but it's not. Instead, it's equal to "Good evening". Thank you.

Sub greetings()
    Select Case Time()
        Case "12:00:00 AM" To "12:00:00 PM"
            Greeting = "Good morning, "
        Case "12:00:01 PM" To "18:00:00 PM"
            Greeting = "Good afternoon, "
        Case Else
            Greeting = "Good evening, "
    End Select
End Sub

 

[Jaafar Tribak]

You should use litteral date values not strings

    Select Case time()
        Case #12:00:00 AM# To #12:00:00 PM#
            Greeting = "Good morning, "
        Case #12:00:01 PM# To #18:00:00 PM#
            Greeting = "Good afternoon, "
        Case Else
            Greeting = "Good evening, "
    End Select

PS: Or convert the strings to dates with the CDate function.

 

[Pookiemeister]

I'm still kinda new to VBA. Can you explain the difference between the two. Thanks

 

[Jaafar Tribak]

I'm still kinda new to VBA. Can you explain the difference between the two. Thanks

The Time vba function returns a variable of Date type
The reason your code didn't work is because you were comparing String values against Date values (returned by the Time function)
To make it work, use Date literals which must be enclosed within number signs (#) or, you could use the CDate vba function to convert the String values to Dates/times as follows:

 Select Case time()
        Case CDate("12:00:00 AM") To CDate("12:00:00 PM")
            Greeting = "Good morning, "
        Case CDate("12:00:01 PM") To CDate("18:00:00 PM")
            Greeting = "Good afternoon, "
        Case Else
            Greeting = "Good evening, "
 End Select

 

[Pookiemeister]

Ok. That makes sense. I've seen the "CDate" used. I don't think I've seen the # used before. Thank you for the explanation.