Use of goto

[Steve001]

Hi all

is there a better way of doing this ? as I was always taught to avoid the "goto" instruction

MSG1 = MsgBox("Pressing this will COMPLETELY replace ALL of the data in the 'Tabs'" & vbCrLf & "Continue ?", vbYesNo, "Sort raw Data")
If MSG1 = vbYes Then
GoTo jump
Else
End

End If
jump:
MsgBox "here we go ... "


Steve

 

[Roxxien]

Hello,

by the way I'm reading your code, you have 2 options to delete your "goto".

1. your goto have no purpose so we just delete it

[COLOR=#333333]MSG1 = MsgBox("Pressing this will COMPLETELY replace ALL of the data in the 'Tabs'" & vbCrLf & "Continue ?", vbYesNo, "Sort raw Data")[/COLOR]
[COLOR=#333333]If MSG1 = vbYes Then[/COLOR]
[COLOR=#333333]Else[/COLOR]
[COLOR=#333333]End[/COLOR]
[COLOR=#333333]End If[/COLOR]
[COLOR=#333333]MsgBox "here we go ... "[/COLOR]

2. we reverse your if

[COLOR=#333333]MSG1 = MsgBox("Pressing this will COMPLETELY replace ALL of the data in the 'Tabs'" & vbCrLf & "Continue ?", vbYesNo, "Sort raw Data")[/COLOR]
[COLOR=#333333]If MSG1 = vbNo Then[/COLOR]
[COLOR=#333333]End
[/COLOR]End If
[COLOR=#333333]MsgBox "here we go ... "
[/COLOR]

You should try the second option in a COPY of your file. If it's not working, use the first option even if it's less logical.

 

[MrKowz]

Personally, I avoid using GoTo as much as possible. It can create some nasty code that is not only difficult to follow, but difficult to debug.

Try having the code operate inside the IF statement.

MSG1 = MsgBox("Pressing this will COMPLETELY replace ALL of the data in the 'Tabs'" & vbCrLf & "Continue ?", vbYesNo, "Sort raw Data")
If MSG1 = vbYes Then
    MsgBox "here we go ... "
    'code you want to operate when they click yes
Else
    'code you want to operate when they click no
End If

 

[Beyond_avarice]

Goto is often referred to as "Spaghetti code" as you can bounce all over the place and it can make coding hard to read. Avoid it with a passion.

Dim MSG1 As String

MSG1 = MsgBox("Pressing this will COMPLETELY replace ALL of the data in the 'Tabs'" & vbCrLf & "Continue ?", vbYesNo, "Sort raw Data")

If MSG1 = vbYes Then
    MsgBox ("here we go.....")
End If

 

[Fluff]

Along with what Roxxien has said, I would also recommend replacing

End

with

Exit Sub

As End can cause problems

 

[Kenneth Hobson]

For that snippet, you can just include jump's MsgBox in the Then. Don't get too worried about using GoTo unless you use more than 1 or 2.

For multiply IFs, one can often use Select Case. The choice depends on your goals.

End is frowned on by some too. Exit Sub will usually suffice.

Sub Test()
 If MsgBox("Pressing this will COMPLETELY replace ALL " _
  & "of the data in the 'Tabs'" & vbCrLf & "Continue ?", _
  vbYesNo, "Sort raw Data") = vbYes Then
    GoTo jump
  Else
End If
Exit Sub

jump:
MsgBox "here we go ... "
End Sub

 

[Steve001]

cheers guys

will have a go swapping my if statements around.

is there a more elegant way of stopping my sheets running then instead of "end" - I don't want anything to continue running I want to exit al macros and stop.