Unload Me still runs following code

[ipbr21054]

I have this code on a userform.

Private Sub TransferInvNumber_Click()
    
    ActiveCell.Value = TransferInvoiceNumber.TextBox1.Value
      Unload Me
      
    Const FILE_PATH As String = "C:\Users\Ian\Desktop\REMOTES ETC\DR\DR COPY INVOICES\"
    If ActiveCell.Column = Columns("P").Column Then
    If Dir(FILE_PATH & ActiveCell.Value & ".pdf") <> "" Then
      ActiveCell.Hyperlinks.Add Anchor:=ActiveCell, Address:=FILE_PATH & ActiveCell.Value & ".pdf"
    Else
      ActiveCell.Hyperlinks.Delete
      MsgBox (FILE_PATH & ActiveCell.Value & ".pdf" & vbNewLine & vbNewLine & "FILE IS NOT IN FOLDER SPECIFIED, PLEASE CHECK PATH IS CORRECT"), vbCritical
    End If
    Else
      MsgBox "PLEASE SELECT AN INVOICE NUMBER.", vbExclamation, "HYPERLINKING THE INVOICE NUMBER"
    End If

End Sub

Sometimes when this form is opened the user sees an error so closes the form by pressing the Red Cross top right.
The code still runs.

Ive added a command button with Unload Me on it but code still runs.

How do i stop the code from running.

 

[RoryA]

If you don't want to run the following code, use Exit Sub. As a general rule, a form should never unload itself.

 

[ipbr21054]

Do you mean

Private Sub CloseForm_Click()
Exit Sub
Unload Me
End Sub

 

[ipbr21054]

Im a bit lost now.

Here is the form.

Command button code.

Private Sub TransferInvNumber_Click()
    
    ActiveCell.Value = TransferInvoiceNumber.TextBox1.Value
      Unload Me
      
    Const FILE_PATH As String = "C:\Users\Ian\Desktop\REMOTES ETC\DR\DR COPY INVOICES\"
    If ActiveCell.Column = Columns("P").Column Then
    If Dir(FILE_PATH & ActiveCell.Value & ".pdf") <> "" Then
      ActiveCell.Hyperlinks.Add Anchor:=ActiveCell, Address:=FILE_PATH & ActiveCell.Value & ".pdf"
    Else
      ActiveCell.Hyperlinks.Delete
      MsgBox (FILE_PATH & ActiveCell.Value & ".pdf" & vbNewLine & vbNewLine & "FILE IS NOT IN FOLDER SPECIFIED, PLEASE CHECK PATH IS CORRECT"), vbCritical
    End If
    Else
      MsgBox "PLEASE SELECT AN INVOICE NUMBER.", vbExclamation, "HYPERLINKING THE INVOICE NUMBER"
    End If

End Sub

Stop & Close code.

Private Sub CloseForm_Click()
Unload Me
End Sub

 

[RoryA]

No, I mean in the code you posted, but you'd need some means of determining whether to exit or not. As that is a click event, I don't see how clicking the X to close the form could trigger it.

 

[ipbr21054]

See my post as yours came through

 

[RoryA]

Still doesn't make sense. Clicking the X to close the form will not run either of those codes.

 

[ipbr21054]

Well it does continue hence why this post is about trying to stop it

 

[ipbr21054]

That userform is part of another code so maybe its just continuing along the way.
Look after the Else statement

    If Len(ActiveCell.Value) <> 0 Then
      ValueInInvoiceCell.Show 'MESSAGE SHOWN IF CUSTOMERS INVOICE CELL IN COLUMN P HAS A VALUE IN IT

    Exit Sub
    Else
      TransferInvoiceNumber.Show 'NOW ENTER INVOICE NUMBER IN CUSTOMERS CELL IN COLUMN P & NOW HYPERLINKED
    End If
    
    With Sheets("INV")
      Worksheets("INV").Activate
    End With
      
     'ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE NOW PRINTED
      answer = MsgBox("INVOICE HAS NOW BEEN SAVED" & vbNewLine & vbNewLine & "DID THE INVOICE PRINT OK FOR YOU ?", vbInformation + vbYesNo, "INVOICE PRINT OK MESSAGE")
 
    If answer = vbNo Then
      ActiveWindow.SelectedSheets.PrintOut copies:=1 'INVOICE PRINTED AGAIN IF FIRST PRINT WAS POOR
    End If

      Range("L4").Value = Range("L4").Value + 1
      Range("G27:L36").ClearContents
      Range("G46:G50").ClearContents
      Range("G13").ClearContents
      Range("G13").Select
      ActiveWorkbook.Save

    End Sub

 

[RoryA]

Yes, that code will continue no matter what you do on your form. If one piece of code needs to react to responses or actions from another form, then that form should have some means of returning a value. The usual way to do that is to add a property (or a public variable if you are feeling lazy ) that can be read by whatever code called the form. The form that is loaded by the calling code should never unload itself, but rather just hide, so that the calling code can check the value of the variable, unload the form, and then proceed, or exit, as appropriate.