Unable to use VBA to open a file selected in the file dialog box.

[helpneeded2]

I am quite new to VBA and have tried a couple different examples for using VBA to open a file that is select via the file dialog box.

After I select the file, nothing happens -- the file does not open.

I can only guess that perhaps the code examples I have been looking at are old, and maybe there is newer code I need to use?

Here is the current code I am trying to use:

Sub FileOpenDialogBox()

'Display a Dialog Box that allows to select a single file.
'The path for the file picked will be stored in fullpath variable
  With Application.FileDialog(msoFileDialogFilePicker)
        'Makes sure the user can select only one file
        .AllowMultiSelect = False
        'Filter to just the following types of files to narrow down selection options
        .Filters.Add "Excel Files", "*.xlsx; *.xlsm; *.xls; *.xlsb", 1
        'Show the dialog box
        .Show
        
        'Store in fullpath variable
        fullpath = .SelectedItems.Item(1)
    End With
    
    'It's a good idea to still check if the file type selected is accurate.
    'Quit the procedure if the user didn't select the type of file we need.
    If InStr(fullpath, ".xls") = 0 Then
        Exit Sub
    End If

    'Open the file selected by the user
    Workbooks.Open fullpath

End Sub

 

[MARK858]

What happens if you change

    If InStr(fullpath, ".xls") = 0 Then
        Exit Sub
    End If

to

    If InStr(fullpath, ".xls*") = 0 Then
        Exit Sub
    End If

 

[helpneeded2]

What happens if you change

    If InStr(fullpath, ".xls") = 0 Then
        Exit Sub
    End If

to

    If InStr(fullpath, ".xls*") = 0 Then
        Exit Sub
    End If

I made the change but still no file opens.

Although I'm a VBA newbie, I also find it odd that there is no Dim statement to initialize the variable type for fullpath?

 

[RoryA]

Your current check is case sensitive, which could be the problem. Try:

    If InStr(1, fullpath, ".xls", vbtextcompare) = 0 Then

instead of the current version.

 

[helpneeded2]

Your current check is case sensitive, which could be the problem. Try:

    If InStr(1, fullpath, ".xls", vbtextcompare) = 0 Then

instead of the current version.

Oh... then magic happens!

Thank you Rory, this now works.

 

[smozgur]

Thank you Rory, this now works.

The marked solution post has been changed accordingly.

@helpneeded2: In your future questions, please mark the post that answered your question as the solution to help future readers. No further action is required for this thread.