Type Mismatch Error

[Juggler_IN]

Hi,

I am getting a Type Mismatch Error in the following code:

Sub z()

Dim u1 As Double, u2 As Double, m As Double, s As Double, i As Long
Dim z(1 To 2) As Double


m = 0
s = 1


For i = 1 To 100


u1 = Rnd()
u2 = Rnd()


z(1) = Sqr(-2 * Log(u2)) * Cos(2 * Application.WorksheetFunction.pi * u1)
z(2) = Sqr(-2 * Log(u2)) * Sin(2 * Application.WorksheetFunction.pi * u1)


Range("E" & i).Value = m + s * z


Next


End Sub

I am not able to identify the cause. Help appreciated.

 

[Eric W]

Sub z()

Dim u1 As Double, u2 As Double, m As Double, s As Double, i As Long
Dim z(1 To 2) As Double


m = 0
s = 1


For i = 1 To 100


u1 = Rnd()
u2 = Rnd()


z(1) = Sqr(-2 * Log(u2)) * Cos(2 * Application.WorksheetFunction.pi * u1)
z(2) = Sqr(-2 * Log(u2)) * Sin(2 * Application.WorksheetFunction.pi * u1)


Range("E" & i).Value = m + s * z


Next


End Sub

You're defining z as a 2-element array, and then at the bottom, you don't give a subscript to z. It should be z(1) or z(2).

 

[Juggler_IN]

Hi Eric,

I am replicating a code I found in Ozgrid by @shg. The link is:
https://www.ozgrid.com/forum/forum/...ue-generation-from-skewed-normal-distribution

In the above code it works, am I missing something else here?

[COLOR=#252C2F][FONT=Courier]RandNorm = af[/FONT][/COLOR]

 

[Eric W]

I don't have time to analyze that entire code, but if you look at the original code, RandNorm is not defined in a Dim statement, making it a variant. This variant happens to hold an array variable, which is passed back as the result of the RandNorm function. Then the calling function refers to the 2 elements of the array separately.

Since I don't entirely understand the original code, or what you're trying to do with it, I can't comment on that. I can just point out why VBA is griping at you.