Trouble with basic C++ Loop

[shyy]

Hi everyone,

I am having trouble with this function.

What the function does is tell the user to input a city name. If the city name is found to output the results. If the city is not found to output "City not found". I got the function to work but the problem is that it repeats "City Not Found" 19 times. How would I modify the following code so it only outputs x amount that is in the .txt file being pulled from and only output once if the city is not found?

Thanks

void QueryCity(City Data[])
{
	system("CLS");
	cout << "Look up which city name: ? ";
	string cityName;
	cin >> cityName;




	for (int i = 0; i < 20; i++)
	{


		if(Data.Name == cityName)
		{
			cout << "City Name: \t" << "# of Outages: \t" << "# of Total Customers: \t" << endl;
			cout << Data.Name << "\t\t";
			cout << Data.NumOfOutages << "\t\t";
			cout << Data.TotalCust << "\t";
			cout << endl;
		}
		else if (Data.Name != cityName)
		{
			cout << "City not found in the database" << endl;
		}
	}


	system("PAUSE");
	system("CLS");
}

 

[xenou]

You don't know if the city is found or not until you've checked all the array elements for a match. One way (there are surely others) would be to use a "flag" variable. Set it to true if you find a match.

Ex. (be warned, my syntax may be bad as I don't write cpp code):

void QueryCity(City Data[])
{
	system("CLS");
	cout << "Look up which city name: ? ";
	string cityName;
	cin >> cityName;
	bool found;




	for (int i = 0; i < 20; i++)
	{


		if(Data[i].Name == cityName)
		{
			cout << "City Name: \t" << "# of Outages: \t" << "# of Total Customers: \t" << endl;
			cout << Data[i].Name << "\t\t";
			cout << Data[i].NumOfOutages << "\t\t";
			cout << Data[i].TotalCust << "\t";
			cout << endl;
			found = true;
		}
	
	
	}
		
	If (!found)
		cout << "City not found in the database" << endl;


	system("PAUSE");
	system("CLS");
}

 

[shyy]

Thanks Xenou!!