Textbook code fails to work

[mikecox39]

I copied this code from Excel VBA: by Nein Smith and I can't get it to work.

The data is a mixed list of number from 1-10 in Column A, color line works but the text line does not

I know there should be a Then in this macro to the author was just trying to show how Conditional logic works, at a very basic level. I guess he thought add the Then part would just cause confusion.

I'm sure there is a simple answer but I don't see it. I understand this is an Offset operation and that it's working in the second line, but why isn't it working in the first line? I expect that it is and that the issue has something to do with the text variable.

Sub DataSet1() Dim FirstNumber As Integer
 
 
FirstNumber = ActiveCell.Value


 If FirstNumber >= 5 Then
       ActiveCell(1, 2).Value = ”Completed”
       ActiveCell(1, 1).Interior.Color = RGB(225, 225, 0)


End If
End Sub

 

[MARK858]

The only thing that I can see is wrong is there are some non standard quotes around Completed.
What happens when you copy/paste the code below and run it?

Sub DataSet1()
    Dim FirstNumber As Integer


    FirstNumber = ActiveCell.Value


    If FirstNumber >= 5 Then
        ActiveCell(1, 2).Value = "Completed"
        ActiveCell(1, 1).Interior.Color = RGB(225, 225, 0)
    End If
End Sub

 

[mikecox39]

The only thing that I can see is wrong is there are some non standard quotes around Completed.
What happens when you copy/paste the code below and run it?

Sub DataSet1()
    Dim FirstNumber As Integer


    FirstNumber = ActiveCell.Value


    If FirstNumber >= 5 Then
        ActiveCell(1, 2).Value = "Completed"
        ActiveCell(1, 1).Interior.Color = RGB(225, 225, 0)
    End If
End Sub

Amazing That's what it was! After running your code and finding that it worked, I went back to the code I sent, that I cut and pasted, and entered new quotes and it worked also. I would never have picked up on that tiny difference!

Thanks!

 

[MARK858]

Hi Mike, you're welcome. It is actually quite a common problem that is encountered when copying code from the internet (just for reference the regular quotes are Ascii character 34 and the other quotes are Ascii character 148 [at least where I am]).

 

[mikecox39]

Hi Mike, you're welcome. It is actually quite a common problem that is encountered when copying code from the internet (just for reference the regular quotes are Ascii character 34 and the other quotes are Ascii character 148 [at least where I am]).

Interesting! Thanks, I'll keep that in mind next time I copy code into XL from the net.