Someone Explain To Me What This Code is Doing?

SanFelippo

Board Regular
Joined
Apr 4, 2017
Messages
124
Hello,

I am doing my best to learn and understand VBA coding, and this one particular piece of code I think I have an idea of what it is doing, but I would rather be absolutely sure so I know I understand it completely. Could someone explain what this is doing? It would be great if you could put comments in the code after some of the lines to explain what they are doing, as well as explain overall what the code is doing. Is it some way of making sure not more than one cell is selected or something like that?


Code:
Private Sub Worksheet_Change(ByVal Target As Range)
Dim rngDV As Range
Dim oldVal As String
Dim newVal As String
If Target.Count > 1 Then GoTo exitHandler
On Error Resume Next
Set rngDV = Cells.SpecialCells(xlCellTypeAllValidation)
On Error GoTo exitHandler
If rngDV Is Nothing Then GoTo exitHandler
If Intersect(Target, rngDV) Is Nothing Then
   'do nothing
Else
  Application.EnableEvents = False
  newVal = Target.Value
  Application.Undo
  oldVal = Target.Value
  Target.Value = newVal
  If Target.Column = 24 Then
    If oldVal = "" Then
      'do nothing
      Else
      If newVal = "" Then
      'do nothing
      Else
      Target.Value = oldVal _
        & ", " & newVal
      End If
    End If
  End If
End If
exitHandler:
  Application.EnableEvents = True
End Sub


Thanks!
 

Excel Facts

Workdays for a market open Mon, Wed, Friday?
Yes! Use "0101011" for the weekend argument in NETWORKDAYS.INTL or WORKDAY.INTL. The 7 digits start on Monday. 1 means it is a weekend.
Code:
Private Sub Worksheet_Change(ByVal Target As Range)
'Define variables
Dim rngDV As Range
Dim oldVal As String
Dim newVal As String

'If the number of cells changed in one action is greater than 1, then go to the label "exitHandler"
If Target.Count > 1 Then GoTo exitHandler

'If an error occurs, continue the code on the next line
On Error Resume Next

'Sets the rngDV variable to be any cell which contains data validation (defined by .SpecialCells(xlCellTypeAllValidation)
Set rngDV = Cells.SpecialCells(xlCellTypeAllValidation)

'If an error occurs, go to the label "exitHandler"
On Error GoTo exitHandler

'If there are no cells which contain data validation, then goto the label "exitHandler"
If rngDV Is Nothing Then GoTo exitHandler

'If the "target" cell (the changed cell) is NOT one of the cells in rngDV (is a cell containing data validation)
If Intersect(Target, rngDV) Is Nothing Then
    'The cell changed was not a data validation cell.  You are doing nothing here.
       'do nothing
    Else
    'The cell changed was a data validation cell.  You are doing things here.
    
    'Turn off application events to prevent the Worksheet_Change macro from firing again, thus creating a potential infinite loop
    Application.EnableEvents = False
    
    'Define the variable "newVal" to be the new value of the changed cell
    newVal = Target.Value
    
    'Undo the changed cell
    Application.Undo
    
    'Define the variable "oldVal" to be the old value (achieved by undoing the change we just made) of the changed cell
    oldVal = Target.Value
    
    'Redefine the cell's new value by calling the newVal variable
    Target.Value = newVal
    
    'If the changed cell's column is 24 then...
    If Target.Column = 24 Then
        'If old value was blank then...
        If oldVal = "" Then
          'do nothing
        Else
            'If new value is blank then...
            If newVal = "" Then
              'do nothing
            Else
                'newVal was not blank.  Concatenate oldVal and newVal together
                Target.Value = oldVal & ", " & newVal
            End If
        End If
    End If
End If

'exitHandler Label - here the Application events are being turned back on
exitHandler:
  Application.EnableEvents = True
End Sub
 
Upvote 0
Any time the value changes in a cell that contains a validation rule, the new value is appended to the previous value with a comma separator.
 
Upvote 0
If you make a change to a cell with data validation in col X, it replaces the new value with a catenation of the prior cell contents and the new contents.

It could be done more simply like this. In the sheet module,

Code:
Private Sub Worksheet_Change(ByVal Target As Range)
  Dim sOld          As String
  Dim sNew          As String

  With Target
    If .Cells.Count = 1 And HasValidation(.Cells) And _
       Not IsEmpty(.Value) And .Column = 24 Then
      sNew = .Value
      On Error GoTo Oops
      Application.EnableEvents = False
      Application.Undo
      sOld = .Value
      .Value = IIf(Len(sOld), sOld & ", ", "") & sNew
    End If
  End With

Oops:
  Application.EnableEvents = True
End Sub

In a standard code module:

Code:
Function HasValidation(r As Range) As Boolean
  On Error Resume Next
  HasValidation = Not Intersect(r.Cells(1), r.Worksheet.Cells.SpecialCells(xlCellTypeAllValidation)) Is Nothing
End Function
 
Last edited:
Upvote 0

Forum statistics

Threads
1,223,911
Messages
6,175,324
Members
452,635
Latest member
laura12345

We've detected that you are using an adblocker.

We have a great community of people providing Excel help here, but the hosting costs are enormous. You can help keep this site running by allowing ads on MrExcel.com.
Allow Ads at MrExcel

Which adblocker are you using?

Disable AdBlock

Follow these easy steps to disable AdBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the icon in the browser’s toolbar.
2)Click on the "Pause on this site" option.
Go back

Disable AdBlock Plus

Follow these easy steps to disable AdBlock Plus

1)Click on the icon in the browser’s toolbar.
2)Click on the toggle to disable it for "mrexcel.com".
Go back

Disable uBlock Origin

Follow these easy steps to disable uBlock Origin

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back

Disable uBlock

Follow these easy steps to disable uBlock

1)Click on the icon in the browser’s toolbar.
2)Click on the "Power" button.
3)Click on the "Refresh" button.
Go back
Back
Top