Small code for temperature converter....

[albertc30]

Hello everybody.

I got this video on youtube and decided to have a go as it seems quite simple.

This will give me an insite how the variables are played about and oerhaps I can understand the logic of all this better.

The code I have seen is in actuall VB express 2010 so I have done my very best to adapt this to VBA excel 2013.

But sadly not all of it works okay.

My code is as follows;

Private Sub CommandButton1_Click()    Dim Celsius As String
    Dim Farenheit As String
    Dim Answer As String
    
[COLOR=#ff0000]    Celsius = texbox1.Text[/COLOR]
[COLOR=#ff0000]    Farenheit = texbox2.Text[/COLOR]
    
    If (TextBox1.Text & TextBox2.Text = vbnullorempty) Then
        MsgBox "Please enter a value on either Celsius or Farenheit box.", vbCritical, "Error"
        Else
            If (TextBox1.Text = vbnullorempty) Then
[COLOR=#ff0000]                Answer = Celsius * 9 / 5 + 32[/COLOR]
                TextBox2.Text = Int(Answer)
            End If
            If (TextBox2.Text = vbnullorempty) Then
[COLOR=#ff0000]                Answer = (Farenheit - 32) * 5 / 9[/COLOR]
                TextBox2.Text = Int(Answer)
            End If
    End If
End Sub

The lines in red are the ones giving me a hard time. I know that the Answer = line is wrong when I have the first two in red as just comments, therefore bypassing them to the next line of code.

Any help as always very much appreciated.

Regards,

Albert

 

[JackDanIce]

You've Dim'd Answer as a string and then trying to pass a numerical value to it, Answer can only hold numerical values. Try Dim Answer as Long and see if that helps

You probably should convert Celsius and Farenheit into numerical values too, i.e. Answer = Val(Celsius) * 9 / 5 + 32

 

[albertc30]

Done that but now flags Answer = (Farenheit - 32) * 5 / 9 or Answer = Celsius * 9 / 5 + 32 as wrong...

 

[JackDanIce]

Wrong meaning what is the error message given? Are all your data types consistent, i.e. you want a numerical answer, are you providing numerical values to your equation?

 

[albertc30]

This is what i got now but still flags those first two lines in red...

Mate, I am learning this, I am a complete rookie... just trying to make sense of the code and it' structure.

Private Sub CommandButton1_Click()
    Dim Celsius As String
    Dim Farenheit As String
    Dim Answer As Long
    
    [COLOR=#ff0000]Celsius = texbox1.Text
    Farenheit = texbox2.Text[/COLOR]
    
    If (TextBox1.Text & TextBox2.Text = vbnullorempty) Then
        MsgBox "Please enter a value on either Celsius or Farenheit box.", vbCritical, "Error"
        Else
            If (TextBox1.Text = vbnullorempty) Then
                [COLOR=#ff0000]Answer = Val(Celsius) * 9 / 5 + 32[/COLOR]
                TextBox2.Text = Int(Answer)
            End If
            If (TextBox2.Text = vbnullorempty) Then
                [COLOR=#ff0000]Answer = Val(Farenheit - 32) * 5 / 9[/COLOR]
                TextBox2.Text = Int(Answer)
            End If
    End If
End Sub

 

[JackDanIce]

Had to modify your code to work for me as I do not know the userform or TextBox you're using but run this in a separate workbook and try to adjust it:

Sub Test()
    Dim Celsius As Long
    Dim Farenheit As Long
    Dim Answer As Long
    
    On Error Resume Next
    Celsius = InputBox("Enter C")
    Farenheit = InputBox("Enter F")
    On Error GoTo 0
    
    If Celsius = vbNull Then Celsius = 0
    If Farenheit = vbNull Then Farenheit = 0
    
    If Not IsNumeric(Celsius + Farenheit) Then
        MsgBox "Please enter a value on either Celsius or Farenheit box.", vbCritical, "Error"
    Else
        If Celsius = 0 Then Answer = Val(Celsius) * 9 / 5 + 32
        If Farenheit = 0 Then Answer = Val(Farenheit - 32) * 5 / 9
        MsgBox Answer
    End If
End Sub

 

[albertc30]

Sorry but I forgot to mention that I am using a userForm1.

The way you have written it it is showing a popup dialog asking for data.

 

[JackDanIce]

Had to modify your code to work for me as I do not know the userform or TextBox you're using but run this in a separate workbook and try to adjust it

See first line in previous reply

 

[albertc30]

Sorry.

How can one share files here?

 

[albertc30]

Sorry.

How can one share files here?

Please see file here...https://www.streamfile.com/pickup/ej4TBCOwzzdQ